Fixe use after free during destruction

Fixe use after free during destruction

Problem scenario happened because destroying a tab was triggering
updating another tab. When the other tab updated various BrowserWindow
methods were called when BrowserView was in a bad state (part way
through destruction).

In theory if detaching tried to update state we would end up in the
same situation as this fixes, but that seems less likely.

BUG=236389
TEST=covered by test now
R=avi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221337

[Avi (use Gerrit), 2013-09-04 21:10:44]

lgtm

m

https://codereview.chromium.org/23800003/diff/1/chrome/browser/ui/views/frame...
File chrome/browser/ui/views/frame/browser_view.cc (right):

https://codereview.chromium.org/23800003/diff/1/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/browser_view.cc:472: }
Wow, this code is even sketchier than the code I wrote. But if it works...

[commit-bot: I haz the power, 2013-09-04 21:17:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/23800003/1

[commit-bot: I haz the power, 2013-09-05 03:34:55]

Change committed as 221337