Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2379993005: Label selection experiment (Closed)

Created:
4 years, 2 months ago by karandeepb
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Label selection experiment.

Patch Set 1 #

Patch Set 2 : Interface done. #

Patch Set 3 : Textfield implements SelectionControllerHost #

Patch Set 4 : Labels also implement SelectionControllerHost. #

Patch Set 5 : Selection color, cursor. #

Patch Set 6 : SelectTillEdge #

Patch Set 7 : Split CL. #

Patch Set 8 : Rebase compile success #

Patch Set 9 : Rebase. #

Patch Set 10 : Persist selection range. #

Patch Set 11 : --- #

Patch Set 12 : UpdateSelectionClipboar #

Patch Set 13 : -- #

Patch Set 14 : --- #

Patch Set 15 : -- #

Patch Set 16 : -- #

Patch Set 17 : Rebase #

Patch Set 18 : Rebase. #

Patch Set 19 : Rebase. #

Patch Set 20 : Rebase. #

Patch Set 21 : -- #

Patch Set 22 : -- #

Patch Set 23 : -- #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -17 lines) Patch
M ui/gfx/render_text.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/render_text_harfbuzz.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/render_text_harfbuzz.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +5 lines, -0 lines 0 comments Download
M ui/gfx/render_text_mac.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/render_text_mac.mm View 1 2 3 4 5 6 7 8 9 14 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/controls/label.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 7 chunks +85 lines, -2 lines 0 comments Download
M ui/views/controls/label.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 18 chunks +246 lines, -7 lines 0 comments Download
M ui/views/controls/link.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/link.cc View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/examples/label_example.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +8 lines, -0 lines 0 comments Download
M ui/views/selection_controller.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/selection_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/style/platform_style.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/style/platform_style.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M ui/views/style/platform_style_mac.mm View 1 2 3 4 5 6 7 8 14 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2408623002 Patch 340001

Messages

Total messages: 23 (23 generated)
karandeepb
The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-13 05:51:17 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379993005/270001
4 years, 2 months ago (2016-10-13 05:51:38 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-13 05:53:23 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/313791)
4 years, 2 months ago (2016-10-13 05:53:24 UTC) #4
karandeepb
The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-13 10:49:18 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379993005/350001
4 years, 2 months ago (2016-10-13 10:49:25 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-13 10:51:17 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/313902)
4 years, 2 months ago (2016-10-13 10:51:17 UTC) #8
karandeepb
The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-14 03:27:44 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379993005/370001
4 years, 2 months ago (2016-10-14 03:27:59 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-14 03:30:09 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/86537) ios-simulator on ...
4 years, 2 months ago (2016-10-14 03:30:10 UTC) #12
karandeepb
The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-14 03:32:10 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379993005/390001
4 years, 2 months ago (2016-10-14 03:32:20 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-14 03:43:51 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/216530) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years, 2 months ago (2016-10-14 03:43:52 UTC) #16
karandeepb
The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-14 03:58:45 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379993005/410001
4 years, 2 months ago (2016-10-14 03:58:55 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-14 04:28:17 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/311608)
4 years, 2 months ago (2016-10-14 04:28:18 UTC) #20
karandeepb
The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-14 05:17:02 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379993005/430001
4 years, 2 months ago (2016-10-14 05:17:10 UTC) #22
karandeepb
4 years, 2 months ago (2016-10-14 06:11:27 UTC) #23 
Description was changed from

==========
Label selection.
==========

to

==========
Label selection experiment.
==========

Powered by Google App Engine
This is Rietveld 408576698