Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: mojo/common/common_custom_types.mojom

Issue 2379993003: Mojo C++ bindings: make String16 and gfx::Size available in Blink (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/common/common_custom_types.mojom
diff --git a/mojo/common/common_custom_types.mojom b/mojo/common/common_custom_types.mojom
index 6c0f4eba773e7103215a1394ea31fc71fde0635b..6dcdf76fec5f044a91ee0361cc9e278462eb4943 100644
--- a/mojo/common/common_custom_types.mojom
+++ b/mojo/common/common_custom_types.mojom
@@ -23,8 +23,13 @@ struct TimeDelta {
[Native]
struct TimeTicks;
-[Native]
-struct String16;
+// Corresponds to |base::string16| in base/strings/string16.h
+// Corresponds to |blink::WebString| in
Tom Sepez 2016/09/29 20:13:08 Wouldn't this violate DEPS, in some sense; I didn'
Zhiqiang Zhang (Slow) 2016/09/29 20:39:31 There some other types which has been mapped to bl
Ken Rockot(use gerrit already) 2016/09/29 22:00:48 This is fine. The typemap which actually imposes D
+// third_party/WebKit/public/platform/WebString.h, and only accept non-null
+// |blink::WebString|.
+struct String16 {
+ array<uint16> data;
+};
// Corresponds to |base::UnguessableToken| in base/unguessable_token.h
struct UnguessableToken {

Powered by Google App Engine
This is Rietveld 408576698