Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2379943002: Revert "Make HTML tree builder simulator switch modes at HTML integration points" (Closed)

Created:
4 years, 2 months ago by dominicc (has gone to gerrit)
Modified:
4 years, 2 months ago
Reviewers:
jwd
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Revert "Make HTML tree builder simulator switch modes at HTML integration points" This reverts commit 30869b3a11a19398108e1ba1254858f3fcc735ca. This is a "manual" (per git drover --help) revert of r403630. Drover can't merge the ToT revert at 6a454415188221d203662987d887c4ab70a2a877 because of the switch from gypi to BUILD.gn files. I tried using drover in refs/branch-heads/2840@{#559} which was rolled out in #567 because it broke the official builders. R=jwd@chromium.org BUG=542803, 639541 Committed: https://chromium.googlesource.com/chromium/src/+/ca0779373e8e350e84eb006ead1baea7957405bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -180 lines) Patch
M third_party/WebKit/LayoutTests/fast/parser/comment-in-title.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/parser/comment-in-title-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTokenizer.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h View 4 chunks +8 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp View 3 chunks +23 lines, -72 lines 0 comments Download
D third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp View 1 chunk +0 lines, -72 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dominicc (has gone to gerrit)
4 years, 2 months ago (2016-09-29 06:51:54 UTC) #1
dominicc (has gone to gerrit)
Committed patchset #1 (id:1) manually as ca0779373e8e350e84eb006ead1baea7957405bb.
4 years, 2 months ago (2016-09-29 07:02:13 UTC) #4
dominicc (has gone to gerrit)
4 years, 2 months ago (2016-09-29 07:14:03 UTC) #5
Message was sent while issue was closed.
On 2016/09/29 at 07:02:13, dominicc wrote:
> Committed patchset #1 (id:1) manually as
ca0779373e8e350e84eb006ead1baea7957405bb.

Gah, I think I may break webkit_unit_tests because something depends on
HTMLTokenizer being CORE_EXPORT. See https://codereview.chromium.org/2379963002

Powered by Google App Engine
This is Rietveld 408576698