Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2379933003:
MD Settings: use overflow: overlay for better centering (Closed)
|
Created:
4 years, 2 months ago by Dan Beam Modified:
4 years, 2 months ago Reviewers:
dpapad CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: use overflow: overlay for better centering
This makes the scrollbar render on top of the content, rather than push
it aside when theres too much content.
BUG=649496
R=dpapad@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/0527e2bfcc1847ed80e3ddd6c0b25cbcc555b4b9
Cr-Commit-Position: refs/heads/master@{#421965}
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
Description was changed from ========== MD Settings: use overflow: overlay for better center This makes the scrollbar render on top of the content, rather than push it aside when theres too much content. BUG=649496 R=dpapad@chromium.org ========== to ========== MD Settings: use overflow: overlay for better center This makes the scrollbar render on top of the content, rather than push it aside when theres too much content. BUG=649496 R=dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== MD Settings: use overflow: overlay for better center This makes the scrollbar render on top of the content, rather than push it aside when theres too much content. BUG=649496 R=dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: use overflow: overlay for better centering This makes the scrollbar render on top of the content, rather than push it aside when theres too much content. BUG=649496 R=dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Is this a Chrome-only value for overlay? I can't find anything about it in the docs at https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-y.
On 2016/09/29 22:05:05, dpapad wrote: > Is this a Chrome-only value for overlay? I can't find anything about it in the > docs at https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-y. yes, both overflow-y and overlay are non-standard i should also note, this is what downloads already does: https://cs.chromium.org/chromium/src/chrome/browser/resources/md_downloads/ma...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== MD Settings: use overflow: overlay for better centering This makes the scrollbar render on top of the content, rather than push it aside when theres too much content. BUG=649496 R=dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: use overflow: overlay for better centering This makes the scrollbar render on top of the content, rather than push it aside when theres too much content. BUG=649496 R=dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== MD Settings: use overflow: overlay for better centering This makes the scrollbar render on top of the content, rather than push it aside when theres too much content. BUG=649496 R=dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: use overflow: overlay for better centering This makes the scrollbar render on top of the content, rather than push it aside when theres too much content. BUG=649496 R=dpapad@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0527e2bfcc1847ed80e3ddd6c0b25cbcc555b4b9 Cr-Commit-Position: refs/heads/master@{#421965} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0527e2bfcc1847ed80e3ddd6c0b25cbcc555b4b9 Cr-Commit-Position: refs/heads/master@{#421965} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
