Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: third_party/WebKit/Source/modules/installation/InstallationServiceImpl.cpp

Issue 2379923002: Implement "appinstalled" event on Android. (Closed)
Patch Set: Fix up some includes. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/installation/InstallationServiceImpl.cpp
diff --git a/third_party/WebKit/Source/modules/installation/InstallationServiceImpl.cpp b/third_party/WebKit/Source/modules/installation/InstallationServiceImpl.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..6cd83d3efdf9e2fc56ca421f3813dadcd6590658
--- /dev/null
+++ b/third_party/WebKit/Source/modules/installation/InstallationServiceImpl.cpp
@@ -0,0 +1,32 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "modules/installation/InstallationServiceImpl.h"
+
+#include "core/events/Event.h"
+#include "core/frame/LocalDOMWindow.h"
haraken 2016/12/15 07:27:50 unused
Matt Giuca 2016/12/16 03:53:46 m_frame->domWindow() is a LocalDOMWindow, so I nee
+#include "core/frame/LocalFrame.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
+#include "wtf/PtrUtil.h"
+#include <utility>
haraken 2016/12/15 07:27:50 unused ?
Matt Giuca 2016/12/16 03:53:46 std::move is in <utility>
+
+namespace blink {
+
+InstallationServiceImpl::InstallationServiceImpl(LocalFrame& frame)
+ : m_frame(frame) {}
+
+// static
+void InstallationServiceImpl::create(
+ LocalFrame* frame,
+ mojom::blink::InstallationServiceRequest request) {
+ mojo::MakeStrongBinding(WTF::makeUnique<InstallationServiceImpl>(*frame),
+ std::move(request));
+}
+
+void InstallationServiceImpl::OnInstall() {
+ m_frame->domWindow()->dispatchEvent(
haraken 2016/12/15 07:27:50 You need to check if (m_frame && m_frame->domWindo
Matt Giuca 2016/12/16 03:53:46 Done.
+ Event::create(EventTypeNames::appinstalled));
+}
+
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698