Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3838)

Unified Diff: chrome/browser/banners/app_banner_manager.h

Issue 2379923002: Implement "appinstalled" event on Android. (Closed)
Patch Set: Rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.h
diff --git a/chrome/browser/banners/app_banner_manager.h b/chrome/browser/banners/app_banner_manager.h
index 15bb380e82d3f31cb699af498d128748e08402fb..63aa732c7b0cedf93a7d54b293da0a7540dba003 100644
--- a/chrome/browser/banners/app_banner_manager.h
+++ b/chrome/browser/banners/app_banner_manager.h
@@ -17,6 +17,7 @@
#include "content/public/browser/web_contents_observer.h"
#include "mojo/public/cpp/bindings/binding.h"
#include "third_party/WebKit/public/platform/modules/app_banner/app_banner.mojom.h"
+#include "third_party/WebKit/public/platform/modules/installation/installation.mojom.h"
dominickn 2016/12/15 03:45:59 Nit: move this include to the cc file.
Matt Giuca 2016/12/15 06:17:23 Done.
class SkBitmap;
struct WebApplicationInfo;
@@ -68,6 +69,11 @@ class AppBannerManager : public content::WebContentsObserver,
// pipeline will be reported to the devtools console.
virtual void RequestAppBanner(const GURL& validated_url, bool is_debug_mode);
+ // Informs the page that it has been installed via an app banner.
+ // This is redundant for the beforeinstallprompt event's promise being
+ // resolved, but is required by the install event spec.
+ void OnInstall();
+
// Sends a message to the renderer that the user accepted the banner. Does
// nothing if |request_id| does not match the current request.
void SendBannerAccepted(int request_id);

Powered by Google App Engine
This is Rietveld 408576698