Implement "appinstalled" event on Android.

third_party/WebKit/Source/modules/installation/InstallationServiceImpl.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef InstallationServiceImpl_h
+#define InstallationServiceImpl_h
+
+#include "modules/ModulesExport.h"
+#include "public/platform/modules/installation/installation.mojom-blink.h"
+
+namespace blink {
+
+class LocalFrame;
+
+class MODULES_EXPORT InstallationServiceImpl final
+    : public mojom::blink::InstallationService {
+ public:
+  explicit InstallationServiceImpl(LocalFrame*);

[dominickn, 2016/12/09 06:08:18]

This should be a reference, not a pointer.

[Matt Giuca, 2016/12/12 04:28:20]

This goes against every fibre of my being. I know Blink people love to accept
them as arguments, but is it really OK to *store* a non-const reference (which I
would have to do here if taking a reference)?

I tried this and I couldn't get the callsite to work properly (some interaction
with wrapWeakPersistent I don't understand). Is this really necessary? Your
AppBannerController just takes a regular pointer....

[dominickn, 2016/12/12 05:03:30]

AppBannerController::bindMojoRequest (aka your create() method) takes a pointer,
because it needs to have wrapWeakPersistent. The constructor takes a reference.
See dcheng's comment at
https://codereview.chromium.org/2393513004/diff/340001/third_party/WebKit/Sou...

[Matt Giuca, 2016/12/14 03:39:40]

Done.

This is super weird then. create takes a pointer, uses * to turn it into a
reference for the ctor, then the ctor immediately passes it to the
WeakPersistent ctor which uses & to turn it back into a pointer.

+
+  static void create(LocalFrame*, mojom::blink::InstallationServiceRequest);
+
+  void OnInstall() override;
+
+ private:
+  LocalFrame* m_frame;
+};
+
+}  // namespace blink
+
+#endif  // InstallationServiceImpl_h