chrome/test/data/banners/appinstalled_test_page.html - Issue 2379923002: Implement "appinstalled" event on Android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/banners/appinstalled_test_page.html

Issue 2379923002: Implement "appinstalled" event on Android. (Closed)

Patch Set: Minor refactor. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	dominickn 2016/10/12 22:35:09 Possibly dumb question: could you put the JS in he Possibly dumb question: could you put the JS in here in an existing test file if nothing else uses the title update to verify? Matt Giuca 2016/12/09 04:36:48 Test pages used in this test: the other pages for Show quoted text On 2016/10/12 22:35:09, dominickn wrote: > Possibly dumb question: could you put the JS in here in an existing test file if > nothing else uses the title update to verify? Test pages used in this test: the other pages for the basic tests here aren't in files at all. They are just hard-coded here, so that doesn't work. Other .html files in this directory: I could but that would unnecessarily complicate them. Best to have a dedicated page to test this thing, I think.
	2 <html>

	3 <head>

	4 <title>appinstalled event test page</title>

	5 <script>

	6 var eventCounter = 0;

	7

	8 function onAppInstalled() {

	9 eventCounter++;

	10 window.document.title = 'Got appinstalled ' + eventCounter

	11 + ' times';

	12 }

	13

	14 window.addEventListener('load', () => {

	15 // Test both the addEventListener and onX attribute versions.

	16 // When an app is installed, this should fire twice.

	17 window.addEventListener('appinstalled', onAppInstalled);

	18 window.onappinstalled = onAppInstalled;

	19 });

	20 </script>

	21 </head>

	22 <body>

	23 </body>

	24 </html>

OLD	NEW