chrome/browser/resources/settings/site_settings/cookie_tree_node.js - Issue 2379913003: Site Settings Desktop: Polish the Site Data details dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/cookie_tree_node.js

Issue 2379913003: Site Settings Desktop: Polish the Site Data details dialog. (Closed)

Patch Set: Address feedback Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/site_settings/site_data_details_dialog.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/cookie_tree_node.js

diff --git a/chrome/browser/resources/settings/site_settings/cookie_tree_node.js b/chrome/browser/resources/settings/site_settings/cookie_tree_node.js

index 1effb8748b248cc31cc36c8c469089ea4a32133d..0763e803229157efe31ac345b5c7ac00a1530b7c 100644

--- a/chrome/browser/resources/settings/site_settings/cookie_tree_node.js

+++ b/chrome/browser/resources/settings/site_settings/cookie_tree_node.js

@@ -173,10 +173,13 @@ cr.define('settings', function() {

// Some types, like quota, have no description nodes.

var dataType = '';

- if (descriptionNode.data_.type != undefined)

+ if (descriptionNode.data_.type != undefined) {

dataType = descriptionNode.data_.type;

- else

- dataType = descriptionNode.children_[0].data_.type;

+ } else {

+ // A description node might not have children when it's deleted.

+ if (descriptionNode.children_.length > 0)

+ dataType = descriptionNode.children_[0].data_.type;

+ }

var count =

(dataType == 'cookie') ? descriptionNode.children_.length : 0;