Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 23799011: Merge 222248 "Revert 220364 "Close the shared audio output devic..." (Closed)

Created:
7 years, 3 months ago by laforge
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Merge 222248 "Revert 220364 "Close the shared audio output devic..." > Revert 220364 "Close the shared audio output device when the tab..." > > > Close the shared audio output device when the tab is closed. > > The audio device is currently shared between multiple media players, but we were missing a step that frees the device when the tab is closed. > > > > Review URL: https://chromiumcodereview.appspot.com/23449012 > > TBR=tommi@chromium.org > BUG=288599 > > Review URL: https://codereview.chromium.org/23442022 TBR=tommi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222260

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M content/renderer/media/media_stream_impl.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
laforge
7 years, 3 months ago (2013-09-10 15:34:43 UTC) #1
laforge
Committed patchset #1 manually as r222260.
7 years, 3 months ago (2013-09-10 15:34:58 UTC) #2
tommi (sloooow) - chröme
7 years, 3 months ago (2013-09-10 15:40:10 UTC) #3
Message was sent while issue was closed.
lgtm. thanks!

Powered by Google App Engine
This is Rietveld 408576698