Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: Source/bindings/v8/custom/V8IDBAnyCustom.cpp

Issue 23799009: Always pass v8::Isolate to v8::Number::New() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 return toV8(impl->idbIndex(), creationContext, isolate); 83 return toV8(impl->idbIndex(), creationContext, isolate);
84 case IDBAny::IDBObjectStoreType: 84 case IDBAny::IDBObjectStoreType:
85 return toV8(impl->idbObjectStore(), creationContext, isolate); 85 return toV8(impl->idbObjectStore(), creationContext, isolate);
86 case IDBAny::IDBTransactionType: 86 case IDBAny::IDBTransactionType:
87 return toV8(impl->idbTransaction(), creationContext, isolate); 87 return toV8(impl->idbTransaction(), creationContext, isolate);
88 case IDBAny::ScriptValueType: 88 case IDBAny::ScriptValueType:
89 return impl->scriptValue().v8Value(); 89 return impl->scriptValue().v8Value();
90 case IDBAny::StringType: 90 case IDBAny::StringType:
91 return v8String(impl->string(), isolate); 91 return v8String(impl->string(), isolate);
92 case IDBAny::IntegerType: 92 case IDBAny::IntegerType:
93 return v8::Number::New(impl->integer()); 93 return v8::Number::New(isolate, impl->integer());
94 case IDBAny::KeyPathType: 94 case IDBAny::KeyPathType:
95 return toV8(impl->keyPath(), creationContext, isolate); 95 return toV8(impl->keyPath(), creationContext, isolate);
96 } 96 }
97 97
98 ASSERT_NOT_REACHED(); 98 ASSERT_NOT_REACHED();
99 return v8::Undefined(); 99 return v8::Undefined();
100 } 100 }
101 101
102 } // namespace WebCore 102 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8NPObject.cpp ('k') | Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698