Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 23799006: Move idltest API to trunk channel (Closed)

Created:
7 years, 3 months ago by pals
Modified:
7 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed review comments #

Patch Set 3 : Rebased #

Patch Set 4 : Fixed the failures #

Patch Set 5 : Setting channel to trunk for the api test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -62 lines) Patch
M chrome/browser/extensions/api/idltest/idltest_api.h View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/idltest/idltest_apitest.cc View 1 2 3 4 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_function_histogram_value.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 2 2 chunks +1 line, -1 line 0 comments Download
D chrome/common/extensions/api/experimental_idltest.idl View 1 chunk +0 lines, -30 lines 0 comments Download
A + chrome/common/extensions/api/idltest.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/api_permission.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/idltest/binary_data/binary.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/idltest/binary_data/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/idltest/nocompile/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/idltest/nocompile/nocompile.js View 1 chunk +1 line, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
pals
+isherman : tools/ +mpcomplete : e/b/e Please review.
7 years, 3 months ago (2013-09-02 12:39:54 UTC) #1
Matt Perry
https://codereview.chromium.org/23799006/diff/1/chrome/browser/extensions/extension_function_histogram_value.h File chrome/browser/extensions/extension_function_histogram_value.h (right): https://codereview.chromium.org/23799006/diff/1/chrome/browser/extensions/extension_function_histogram_value.h#newcode619 chrome/browser/extensions/extension_function_histogram_value.h:619: IDLTEST_GETARRAYBUFFER, When you're moving APIs out of experimental, just ...
7 years, 3 months ago (2013-09-03 19:29:24 UTC) #2
Matt Perry
also, you need to change histograms.xml
7 years, 3 months ago (2013-09-03 19:30:27 UTC) #3
pals
Fixed. Please review again. https://codereview.chromium.org/23799006/diff/1/chrome/browser/extensions/extension_function_histogram_value.h File chrome/browser/extensions/extension_function_histogram_value.h (right): https://codereview.chromium.org/23799006/diff/1/chrome/browser/extensions/extension_function_histogram_value.h#newcode619 chrome/browser/extensions/extension_function_histogram_value.h:619: IDLTEST_GETARRAYBUFFER, On 2013/09/03 19:29:24, Matt ...
7 years, 3 months ago (2013-09-04 13:35:54 UTC) #4
Matt Perry
lgtm
7 years, 3 months ago (2013-09-04 19:36:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/23799006/7001
7 years, 3 months ago (2013-09-10 06:30:04 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/api/_api_features.json: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-10 06:30:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/23799006/17001
7 years, 3 months ago (2013-09-10 06:54:33 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=166630
7 years, 3 months ago (2013-09-10 07:35:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/23799006/44001
7 years, 3 months ago (2013-09-10 09:30:29 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests, telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=167370
7 years, 3 months ago (2013-09-10 10:30:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/23799006/67001
7 years, 3 months ago (2013-09-10 11:51:03 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_net_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=195568
7 years, 3 months ago (2013-09-10 17:03:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/23799006/67001
7 years, 3 months ago (2013-09-11 02:19:17 UTC) #14
commit-bot: I haz the power
7 years, 3 months ago (2013-09-11 14:46:33 UTC) #15
Message was sent while issue was closed.
Change committed as 222549

Powered by Google App Engine
This is Rietveld 408576698