Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/browser/android/bookmarks/partner_bookmarks_reader.cc

Issue 2379863002: Fix object ownership in ui/base/models. (Closed)
Patch Set: chromeos/android Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/bookmarks/partner_bookmarks_reader.cc
diff --git a/chrome/browser/android/bookmarks/partner_bookmarks_reader.cc b/chrome/browser/android/bookmarks/partner_bookmarks_reader.cc
index c0b724b6ea9237251d9de21b4596afff12ce4d12..c07cb85b00e3d9e7ffe2ae3fd84b08402d2dc019 100644
--- a/chrome/browser/android/bookmarks/partner_bookmarks_reader.cc
+++ b/chrome/browser/android/bookmarks/partner_bookmarks_reader.cc
@@ -7,6 +7,7 @@
#include "base/android/jni_android.h"
#include "base/android/jni_string.h"
#include "base/logging.h"
+#include "base/memory/ptr_util.h"
#include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/favicon/favicon_service_factory.h"
@@ -179,7 +180,8 @@ jlong PartnerBookmarksReader::AddPartnerBookmark(
<< parent_id << ": adding to the root";
parent = wip_partner_bookmarks_root_.get();
}
- const_cast<BookmarkNode*>(parent)->Add(node, parent->child_count());
+ const_cast<BookmarkNode*>(parent)->Add(base::WrapUnique(node),
+ parent->child_count());
} else {
node = new BookmarkPermanentNode(wip_next_available_id_++);
node->SetTitle(title);

Powered by Google App Engine
This is Rietveld 408576698