components/bookmarks/browser/bookmark_storage.cc - Issue 2379863002: Fix object ownership in ui/base/models.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_storage.cc

Issue 2379863002: Fix object ownership in ui/base/models. (Closed)

Patch Set: fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks/browser/bookmark_storage.cc

diff --git a/components/bookmarks/browser/bookmark_storage.cc b/components/bookmarks/browser/bookmark_storage.cc

index 4acd103a2c71d3618803a60dee7010825b2c5c74..b3f424f577927cd77303c8ddca298c40dd5e49f7 100644

--- a/components/bookmarks/browser/bookmark_storage.cc

+++ b/components/bookmarks/browser/bookmark_storage.cc

@@ -101,7 +101,7 @@ void LoadCallback(const base::FilePath& path,

AddBookmarksToIndex(details.get(), details->other_folder_node());

AddBookmarksToIndex(details.get(), details->mobile_folder_node());

for (size_t i = 0; i < extra_nodes.size(); ++i)

- AddBookmarksToIndex(details.get(), extra_nodes[i]);

+ AddBookmarksToIndex(details.get(), extra_nodes[i].get());

UMA_HISTOGRAM_TIMES("Bookmarks.CreateBookmarkIndexTime",

TimeTicks::Now() - start_time);

}