Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: chrome/browser/android/bookmarks/partner_bookmarks_shim.h

Issue 2379863002: Fix object ownership in ui/base/models. (Closed)
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/bookmarks/partner_bookmarks_shim.h
diff --git a/chrome/browser/android/bookmarks/partner_bookmarks_shim.h b/chrome/browser/android/bookmarks/partner_bookmarks_shim.h
index 7454d80a9f22cb9dfdfc2f35ecc1b369336d17bc..af6ab2812302e1dff87da0473f41839a10ded069 100644
--- a/chrome/browser/android/bookmarks/partner_bookmarks_shim.h
+++ b/chrome/browser/android/bookmarks/partner_bookmarks_shim.h
@@ -94,8 +94,9 @@ class PartnerBookmarksShim : public base::SupportsUserData::Data {
const bookmarks::BookmarkNode* GetPartnerBookmarksRoot() const;
// Sets the root node of the partner bookmarks and notifies any observers that
- // the shim has now been loaded. Takes ownership of |root_node|.
- void SetPartnerBookmarksRoot(bookmarks::BookmarkNode* root_node);
+ // the shim has now been loaded.
+ void SetPartnerBookmarksRoot(
+ std::unique_ptr<bookmarks::BookmarkNode> root_node);
// Used as a "unique" identifier of the partner bookmark node for the purposes
// of node deletion and title editing. Two bookmarks with the same URLs and

Powered by Google App Engine
This is Rietveld 408576698