Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Side by Side Diff: ui/base/models/tree_node_iterator_unittest.cc

Issue 2379863002: Fix object ownership in ui/base/models. (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/base/models/tree_node_iterator.h ('k') | ui/base/models/tree_node_model.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/base/models/tree_node_iterator.h" 5 #include "ui/base/models/tree_node_iterator.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/memory/ptr_util.h"
8 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
9 #include "ui/base/models/tree_node_model.h" 10 #include "ui/base/models/tree_node_model.h"
10 11
11 namespace ui { 12 namespace ui {
12 13
13 namespace { 14 namespace {
14 15
15 typedef TreeNodeWithValue<int> TestNode; 16 using TestNode = TreeNodeWithValue<int>;
16 17
17 bool PruneOdd(TestNode* node) { 18 bool PruneOdd(TestNode* node) {
18 return node->value % 2; 19 return node->value % 2;
19 } 20 }
20 21
21 bool PruneEven(TestNode* node) { 22 bool PruneEven(TestNode* node) {
22 return !PruneOdd(node); 23 return !PruneOdd(node);
23 } 24 }
24 25
25 TEST(TreeNodeIteratorTest, Basic) { 26 TEST(TreeNodeIteratorTest, Basic) {
26 TestNode root; 27 TestNode root;
27 root.Add(new TestNode(), 0); 28 root.Add(base::MakeUnique<TestNode>(), 0);
28 root.Add(new TestNode(), 1); 29 root.Add(base::MakeUnique<TestNode>(), 1);
29 TestNode* f3 = new TestNode(); 30 TestNode* f3 = root.Add(base::MakeUnique<TestNode>(), 2);
30 root.Add(f3, 2); 31 TestNode* f4 = f3->Add(base::MakeUnique<TestNode>(), 0);
31 TestNode* f4 = new TestNode(); 32 f4->Add(base::MakeUnique<TestNode>(), 0);
32 f3->Add(f4, 0);
33 f4->Add(new TestNode(), 0);
34 33
35 TreeNodeIterator<TestNode> iterator(&root); 34 TreeNodeIterator<TestNode> iterator(&root);
36 ASSERT_TRUE(iterator.has_next()); 35 ASSERT_TRUE(iterator.has_next());
37 ASSERT_EQ(root.GetChild(0), iterator.Next()); 36 ASSERT_EQ(root.GetChild(0), iterator.Next());
38 37
39 ASSERT_TRUE(iterator.has_next()); 38 ASSERT_TRUE(iterator.has_next());
40 ASSERT_EQ(root.GetChild(1), iterator.Next()); 39 ASSERT_EQ(root.GetChild(1), iterator.Next());
41 40
42 ASSERT_TRUE(iterator.has_next()); 41 ASSERT_TRUE(iterator.has_next());
43 ASSERT_EQ(root.GetChild(2), iterator.Next()); 42 ASSERT_EQ(root.GetChild(2), iterator.Next());
44 43
45 ASSERT_TRUE(iterator.has_next()); 44 ASSERT_TRUE(iterator.has_next());
46 ASSERT_EQ(f4, iterator.Next()); 45 ASSERT_EQ(f4, iterator.Next());
47 46
48 ASSERT_TRUE(iterator.has_next()); 47 ASSERT_TRUE(iterator.has_next());
49 ASSERT_EQ(f4->GetChild(0), iterator.Next()); 48 ASSERT_EQ(f4->GetChild(0), iterator.Next());
50 49
51 ASSERT_FALSE(iterator.has_next()); 50 ASSERT_FALSE(iterator.has_next());
52 } 51 }
53 52
54 // The tree used for testing: 53 // The tree used for testing:
55 // * + 1 54 // * + 1
56 // + 2 55 // + 2
57 // + 3 + 4 + 5 56 // + 3 + 4 + 5
58 // + 7 57 // + 7
59 TEST(TreeNodeIteratorTest, Prune) { 58 TEST(TreeNodeIteratorTest, Prune) {
60 TestNode root; 59 TestNode root;
61 root.Add(new TestNode(1), 0); 60 root.Add(base::MakeUnique<TestNode>(1), 0);
62 root.Add(new TestNode(2), 1); 61 root.Add(base::MakeUnique<TestNode>(2), 1);
63 TestNode* f3 = new TestNode(3); 62 TestNode* f3 = root.Add(base::MakeUnique<TestNode>(3), 2);
64 root.Add(f3, 2); 63 TestNode* f4 = f3->Add(base::MakeUnique<TestNode>(4), 0);
65 TestNode* f4 = new TestNode(4); 64 f4->Add(base::MakeUnique<TestNode>(5), 0);
66 f3->Add(f4, 0); 65 f3->Add(base::MakeUnique<TestNode>(7), 1);
67 f4->Add(new TestNode(5), 0);
68 f3->Add(new TestNode(7), 1);
69 66
70 TreeNodeIterator<TestNode> odd_iterator(&root, base::Bind(&PruneOdd)); 67 TreeNodeIterator<TestNode> odd_iterator(&root, base::Bind(&PruneOdd));
71 ASSERT_TRUE(odd_iterator.has_next()); 68 ASSERT_TRUE(odd_iterator.has_next());
72 ASSERT_EQ(2, odd_iterator.Next()->value); 69 ASSERT_EQ(2, odd_iterator.Next()->value);
73 ASSERT_FALSE(odd_iterator.has_next()); 70 ASSERT_FALSE(odd_iterator.has_next());
74 71
75 TreeNodeIterator<TestNode> even_iterator(&root, base::Bind(&PruneEven)); 72 TreeNodeIterator<TestNode> even_iterator(&root, base::Bind(&PruneEven));
76 ASSERT_TRUE(even_iterator.has_next()); 73 ASSERT_TRUE(even_iterator.has_next());
77 ASSERT_EQ(1, even_iterator.Next()->value); 74 ASSERT_EQ(1, even_iterator.Next()->value);
78 ASSERT_TRUE(even_iterator.has_next()); 75 ASSERT_TRUE(even_iterator.has_next());
79 ASSERT_EQ(3, even_iterator.Next()->value); 76 ASSERT_EQ(3, even_iterator.Next()->value);
80 ASSERT_TRUE(even_iterator.has_next()); 77 ASSERT_TRUE(even_iterator.has_next());
81 ASSERT_EQ(7, even_iterator.Next()->value); 78 ASSERT_EQ(7, even_iterator.Next()->value);
82 ASSERT_FALSE(even_iterator.has_next()); 79 ASSERT_FALSE(even_iterator.has_next());
83 } 80 }
84 81
85 } // namespace 82 } // namespace
86 83
87 } // namespace ui 84 } // namespace ui
OLDNEW
« no previous file with comments | « ui/base/models/tree_node_iterator.h ('k') | ui/base/models/tree_node_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698