Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: chrome/browser/browsing_data/cookies_tree_model.h

Issue 2379863002: Fix object ownership in ui/base/models. (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BROWSING_DATA_COOKIES_TREE_MODEL_H_ 5 #ifndef CHROME_BROWSER_BROWSING_DATA_COOKIES_TREE_MODEL_H_
6 #define CHROME_BROWSER_BROWSING_DATA_COOKIES_TREE_MODEL_H_ 6 #define CHROME_BROWSER_BROWSING_DATA_COOKIES_TREE_MODEL_H_
7 7
8 // TODO(viettrungluu): This header file #includes far too much and has too much 8 // TODO(viettrungluu): This header file #includes far too much and has too much
9 // inline code (which shouldn't be inline). 9 // inline code (which shouldn't be inline).
10 10
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 virtual void DeleteStoredObjects(); 171 virtual void DeleteStoredObjects();
172 172
173 // Gets a pointer back to the associated model for the tree we are in. 173 // Gets a pointer back to the associated model for the tree we are in.
174 virtual CookiesTreeModel* GetModel() const; 174 virtual CookiesTreeModel* GetModel() const;
175 175
176 // Returns a struct with detailed information used to populate the details 176 // Returns a struct with detailed information used to populate the details
177 // part of the view. 177 // part of the view.
178 virtual DetailedInfo GetDetailedInfo() const = 0; 178 virtual DetailedInfo GetDetailedInfo() const = 0;
179 179
180 protected: 180 protected:
181 void AddChildSortedByTitle(CookieTreeNode* new_child); 181 void AddChildSortedByTitle(std::unique_ptr<CookieTreeNode> new_child);
182 182
183 private: 183 private:
184 DISALLOW_COPY_AND_ASSIGN(CookieTreeNode); 184 DISALLOW_COPY_AND_ASSIGN(CookieTreeNode);
185 }; 185 };
186 186
187 // CookieTreeRootNode --------------------------------------------------------- 187 // CookieTreeRootNode ---------------------------------------------------------
188 // The node at the root of the CookieTree that gets inserted into the view. 188 // The node at the root of the CookieTree that gets inserted into the view.
189 class CookieTreeRootNode : public CookieTreeNode { 189 class CookieTreeRootNode : public CookieTreeNode {
190 public: 190 public:
191 explicit CookieTreeRootNode(CookiesTreeModel* model); 191 explicit CookieTreeRootNode(CookiesTreeModel* model);
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 DISALLOW_COPY_AND_ASSIGN(CookieTreeCookieNode); 292 DISALLOW_COPY_AND_ASSIGN(CookieTreeCookieNode);
293 }; 293 };
294 294
295 class CookieTreeCookiesNode : public CookieTreeNode { 295 class CookieTreeCookiesNode : public CookieTreeNode {
296 public: 296 public:
297 CookieTreeCookiesNode(); 297 CookieTreeCookiesNode();
298 ~CookieTreeCookiesNode() override; 298 ~CookieTreeCookiesNode() override;
299 299
300 DetailedInfo GetDetailedInfo() const override; 300 DetailedInfo GetDetailedInfo() const override;
301 301
302 void AddCookieNode(CookieTreeCookieNode* child) { 302 void AddCookieNode(std::unique_ptr<CookieTreeCookieNode> child) {
303 AddChildSortedByTitle(child); 303 AddChildSortedByTitle(std::move(child));
304 } 304 }
305 305
306 private: 306 private:
307 DISALLOW_COPY_AND_ASSIGN(CookieTreeCookiesNode); 307 DISALLOW_COPY_AND_ASSIGN(CookieTreeCookiesNode);
308 }; 308 };
309 309
310 // CookieTreeAppCacheNode ----------------------------------------------------- 310 // CookieTreeAppCacheNode -----------------------------------------------------
311 class CookieTreeAppCacheNode : public CookieTreeNode { 311 class CookieTreeAppCacheNode : public CookieTreeNode {
312 public: 312 public:
313 friend class CookieTreeAppCachesNode; 313 friend class CookieTreeAppCachesNode;
(...skipping 14 matching lines...) Expand all
328 DISALLOW_COPY_AND_ASSIGN(CookieTreeAppCacheNode); 328 DISALLOW_COPY_AND_ASSIGN(CookieTreeAppCacheNode);
329 }; 329 };
330 330
331 class CookieTreeAppCachesNode : public CookieTreeNode { 331 class CookieTreeAppCachesNode : public CookieTreeNode {
332 public: 332 public:
333 CookieTreeAppCachesNode(); 333 CookieTreeAppCachesNode();
334 ~CookieTreeAppCachesNode() override; 334 ~CookieTreeAppCachesNode() override;
335 335
336 DetailedInfo GetDetailedInfo() const override; 336 DetailedInfo GetDetailedInfo() const override;
337 337
338 void AddAppCacheNode(CookieTreeAppCacheNode* child) { 338 void AddAppCacheNode(std::unique_ptr<CookieTreeAppCacheNode> child) {
339 AddChildSortedByTitle(child); 339 AddChildSortedByTitle(std::move(child));
340 } 340 }
341 341
342 private: 342 private:
343 DISALLOW_COPY_AND_ASSIGN(CookieTreeAppCachesNode); 343 DISALLOW_COPY_AND_ASSIGN(CookieTreeAppCachesNode);
344 }; 344 };
345 345
346 // CookieTreeDatabaseNode ----------------------------------------------------- 346 // CookieTreeDatabaseNode -----------------------------------------------------
347 class CookieTreeDatabaseNode : public CookieTreeNode { 347 class CookieTreeDatabaseNode : public CookieTreeNode {
348 public: 348 public:
349 friend class CookieTreeDatabasesNode; 349 friend class CookieTreeDatabasesNode;
(...skipping 17 matching lines...) Expand all
367 DISALLOW_COPY_AND_ASSIGN(CookieTreeDatabaseNode); 367 DISALLOW_COPY_AND_ASSIGN(CookieTreeDatabaseNode);
368 }; 368 };
369 369
370 class CookieTreeDatabasesNode : public CookieTreeNode { 370 class CookieTreeDatabasesNode : public CookieTreeNode {
371 public: 371 public:
372 CookieTreeDatabasesNode(); 372 CookieTreeDatabasesNode();
373 ~CookieTreeDatabasesNode() override; 373 ~CookieTreeDatabasesNode() override;
374 374
375 DetailedInfo GetDetailedInfo() const override; 375 DetailedInfo GetDetailedInfo() const override;
376 376
377 void AddDatabaseNode(CookieTreeDatabaseNode* child) { 377 void AddDatabaseNode(std::unique_ptr<CookieTreeDatabaseNode> child) {
378 AddChildSortedByTitle(child); 378 AddChildSortedByTitle(std::move(child));
379 } 379 }
380 380
381 private: 381 private:
382 DISALLOW_COPY_AND_ASSIGN(CookieTreeDatabasesNode); 382 DISALLOW_COPY_AND_ASSIGN(CookieTreeDatabasesNode);
383 }; 383 };
384 384
385 // CookieTreeFileSystemNode -------------------------------------------------- 385 // CookieTreeFileSystemNode --------------------------------------------------
386 class CookieTreeFileSystemNode : public CookieTreeNode { 386 class CookieTreeFileSystemNode : public CookieTreeNode {
387 public: 387 public:
388 friend class CookieTreeFileSystemsNode; 388 friend class CookieTreeFileSystemsNode;
(...skipping 17 matching lines...) Expand all
406 DISALLOW_COPY_AND_ASSIGN(CookieTreeFileSystemNode); 406 DISALLOW_COPY_AND_ASSIGN(CookieTreeFileSystemNode);
407 }; 407 };
408 408
409 class CookieTreeFileSystemsNode : public CookieTreeNode { 409 class CookieTreeFileSystemsNode : public CookieTreeNode {
410 public: 410 public:
411 CookieTreeFileSystemsNode(); 411 CookieTreeFileSystemsNode();
412 ~CookieTreeFileSystemsNode() override; 412 ~CookieTreeFileSystemsNode() override;
413 413
414 DetailedInfo GetDetailedInfo() const override; 414 DetailedInfo GetDetailedInfo() const override;
415 415
416 void AddFileSystemNode(CookieTreeFileSystemNode* child) { 416 void AddFileSystemNode(std::unique_ptr<CookieTreeFileSystemNode> child) {
417 AddChildSortedByTitle(child); 417 AddChildSortedByTitle(std::move(child));
418 } 418 }
419 419
420 private: 420 private:
421 DISALLOW_COPY_AND_ASSIGN(CookieTreeFileSystemsNode); 421 DISALLOW_COPY_AND_ASSIGN(CookieTreeFileSystemsNode);
422 }; 422 };
423 423
424 // CookieTreeLocalStorageNode ------------------------------------------------- 424 // CookieTreeLocalStorageNode -------------------------------------------------
425 class CookieTreeLocalStorageNode : public CookieTreeNode { 425 class CookieTreeLocalStorageNode : public CookieTreeNode {
426 public: 426 public:
427 // local_storage_info should remain valid at least as long as the 427 // local_storage_info should remain valid at least as long as the
(...skipping 16 matching lines...) Expand all
444 DISALLOW_COPY_AND_ASSIGN(CookieTreeLocalStorageNode); 444 DISALLOW_COPY_AND_ASSIGN(CookieTreeLocalStorageNode);
445 }; 445 };
446 446
447 class CookieTreeLocalStoragesNode : public CookieTreeNode { 447 class CookieTreeLocalStoragesNode : public CookieTreeNode {
448 public: 448 public:
449 CookieTreeLocalStoragesNode(); 449 CookieTreeLocalStoragesNode();
450 ~CookieTreeLocalStoragesNode() override; 450 ~CookieTreeLocalStoragesNode() override;
451 451
452 DetailedInfo GetDetailedInfo() const override; 452 DetailedInfo GetDetailedInfo() const override;
453 453
454 void AddLocalStorageNode(CookieTreeLocalStorageNode* child) { 454 void AddLocalStorageNode(std::unique_ptr<CookieTreeLocalStorageNode> child) {
455 AddChildSortedByTitle(child); 455 AddChildSortedByTitle(std::move(child));
456 } 456 }
457 457
458 private: 458 private:
459 DISALLOW_COPY_AND_ASSIGN(CookieTreeLocalStoragesNode); 459 DISALLOW_COPY_AND_ASSIGN(CookieTreeLocalStoragesNode);
460 }; 460 };
461 461
462 462
463 // CookieTreeSessionStorageNode ----------------------------------------------- 463 // CookieTreeSessionStorageNode -----------------------------------------------
464 class CookieTreeSessionStorageNode : public CookieTreeNode { 464 class CookieTreeSessionStorageNode : public CookieTreeNode {
465 public: 465 public:
(...skipping 17 matching lines...) Expand all
483 DISALLOW_COPY_AND_ASSIGN(CookieTreeSessionStorageNode); 483 DISALLOW_COPY_AND_ASSIGN(CookieTreeSessionStorageNode);
484 }; 484 };
485 485
486 class CookieTreeSessionStoragesNode : public CookieTreeNode { 486 class CookieTreeSessionStoragesNode : public CookieTreeNode {
487 public: 487 public:
488 CookieTreeSessionStoragesNode(); 488 CookieTreeSessionStoragesNode();
489 ~CookieTreeSessionStoragesNode() override; 489 ~CookieTreeSessionStoragesNode() override;
490 490
491 DetailedInfo GetDetailedInfo() const override; 491 DetailedInfo GetDetailedInfo() const override;
492 492
493 void AddSessionStorageNode(CookieTreeSessionStorageNode* child) { 493 void AddSessionStorageNode(
494 AddChildSortedByTitle(child); 494 std::unique_ptr<CookieTreeSessionStorageNode> child) {
495 AddChildSortedByTitle(std::move(child));
495 } 496 }
496 497
497 private: 498 private:
498 DISALLOW_COPY_AND_ASSIGN(CookieTreeSessionStoragesNode); 499 DISALLOW_COPY_AND_ASSIGN(CookieTreeSessionStoragesNode);
499 }; 500 };
500 501
501 // CookieTreeIndexedDBNode ----------------------------------------------- 502 // CookieTreeIndexedDBNode -----------------------------------------------
502 class CookieTreeIndexedDBNode : public CookieTreeNode { 503 class CookieTreeIndexedDBNode : public CookieTreeNode {
503 public: 504 public:
504 // indexed_db_info should remain valid at least as long as the 505 // indexed_db_info should remain valid at least as long as the
(...skipping 16 matching lines...) Expand all
521 DISALLOW_COPY_AND_ASSIGN(CookieTreeIndexedDBNode); 522 DISALLOW_COPY_AND_ASSIGN(CookieTreeIndexedDBNode);
522 }; 523 };
523 524
524 class CookieTreeIndexedDBsNode : public CookieTreeNode { 525 class CookieTreeIndexedDBsNode : public CookieTreeNode {
525 public: 526 public:
526 CookieTreeIndexedDBsNode(); 527 CookieTreeIndexedDBsNode();
527 ~CookieTreeIndexedDBsNode() override; 528 ~CookieTreeIndexedDBsNode() override;
528 529
529 DetailedInfo GetDetailedInfo() const override; 530 DetailedInfo GetDetailedInfo() const override;
530 531
531 void AddIndexedDBNode(CookieTreeIndexedDBNode* child) { 532 void AddIndexedDBNode(std::unique_ptr<CookieTreeIndexedDBNode> child) {
532 AddChildSortedByTitle(child); 533 AddChildSortedByTitle(std::move(child));
533 } 534 }
534 535
535 private: 536 private:
536 DISALLOW_COPY_AND_ASSIGN(CookieTreeIndexedDBsNode); 537 DISALLOW_COPY_AND_ASSIGN(CookieTreeIndexedDBsNode);
537 }; 538 };
538 539
539 // CookieTreeQuotaNode -------------------------------------------------- 540 // CookieTreeQuotaNode --------------------------------------------------
540 class CookieTreeQuotaNode : public CookieTreeNode { 541 class CookieTreeQuotaNode : public CookieTreeNode {
541 public: 542 public:
542 // quota_info should remain valid at least as long as the CookieTreeQuotaNode 543 // quota_info should remain valid at least as long as the CookieTreeQuotaNode
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
579 DISALLOW_COPY_AND_ASSIGN(CookieTreeChannelIDNode); 580 DISALLOW_COPY_AND_ASSIGN(CookieTreeChannelIDNode);
580 }; 581 };
581 582
582 class CookieTreeChannelIDsNode : public CookieTreeNode { 583 class CookieTreeChannelIDsNode : public CookieTreeNode {
583 public: 584 public:
584 CookieTreeChannelIDsNode(); 585 CookieTreeChannelIDsNode();
585 ~CookieTreeChannelIDsNode() override; 586 ~CookieTreeChannelIDsNode() override;
586 587
587 DetailedInfo GetDetailedInfo() const override; 588 DetailedInfo GetDetailedInfo() const override;
588 589
589 void AddChannelIDNode(CookieTreeChannelIDNode* child) { 590 void AddChannelIDNode(std::unique_ptr<CookieTreeChannelIDNode> child) {
590 AddChildSortedByTitle(child); 591 AddChildSortedByTitle(std::move(child));
591 } 592 }
592 593
593 private: 594 private:
594 DISALLOW_COPY_AND_ASSIGN(CookieTreeChannelIDsNode); 595 DISALLOW_COPY_AND_ASSIGN(CookieTreeChannelIDsNode);
595 }; 596 };
596 597
597 // CookieTreeServiceWorkerNode ----------------------------------------------- 598 // CookieTreeServiceWorkerNode -----------------------------------------------
598 class CookieTreeServiceWorkerNode : public CookieTreeNode { 599 class CookieTreeServiceWorkerNode : public CookieTreeNode {
599 public: 600 public:
600 // service_worker_info should remain valid at least as long as the 601 // service_worker_info should remain valid at least as long as the
(...skipping 14 matching lines...) Expand all
615 DISALLOW_COPY_AND_ASSIGN(CookieTreeServiceWorkerNode); 616 DISALLOW_COPY_AND_ASSIGN(CookieTreeServiceWorkerNode);
616 }; 617 };
617 618
618 class CookieTreeServiceWorkersNode : public CookieTreeNode { 619 class CookieTreeServiceWorkersNode : public CookieTreeNode {
619 public: 620 public:
620 CookieTreeServiceWorkersNode(); 621 CookieTreeServiceWorkersNode();
621 ~CookieTreeServiceWorkersNode() override; 622 ~CookieTreeServiceWorkersNode() override;
622 623
623 DetailedInfo GetDetailedInfo() const override; 624 DetailedInfo GetDetailedInfo() const override;
624 625
625 void AddServiceWorkerNode(CookieTreeServiceWorkerNode* child) { 626 void AddServiceWorkerNode(
626 AddChildSortedByTitle(child); 627 std::unique_ptr<CookieTreeServiceWorkerNode> child) {
628 AddChildSortedByTitle(std::move(child));
627 } 629 }
628 630
629 private: 631 private:
630 DISALLOW_COPY_AND_ASSIGN(CookieTreeServiceWorkersNode); 632 DISALLOW_COPY_AND_ASSIGN(CookieTreeServiceWorkersNode);
631 }; 633 };
632 634
633 // CookieTreeCacheStorageNode ----------------------------------------------- 635 // CookieTreeCacheStorageNode -----------------------------------------------
634 class CookieTreeCacheStorageNode : public CookieTreeNode { 636 class CookieTreeCacheStorageNode : public CookieTreeNode {
635 public: 637 public:
636 // cache_storage_info should remain valid at least as long as the 638 // cache_storage_info should remain valid at least as long as the
(...skipping 14 matching lines...) Expand all
651 DISALLOW_COPY_AND_ASSIGN(CookieTreeCacheStorageNode); 653 DISALLOW_COPY_AND_ASSIGN(CookieTreeCacheStorageNode);
652 }; 654 };
653 655
654 class CookieTreeCacheStoragesNode : public CookieTreeNode { 656 class CookieTreeCacheStoragesNode : public CookieTreeNode {
655 public: 657 public:
656 CookieTreeCacheStoragesNode(); 658 CookieTreeCacheStoragesNode();
657 ~CookieTreeCacheStoragesNode() override; 659 ~CookieTreeCacheStoragesNode() override;
658 660
659 DetailedInfo GetDetailedInfo() const override; 661 DetailedInfo GetDetailedInfo() const override;
660 662
661 void AddCacheStorageNode(CookieTreeCacheStorageNode* child) { 663 void AddCacheStorageNode(std::unique_ptr<CookieTreeCacheStorageNode> child) {
662 AddChildSortedByTitle(child); 664 AddChildSortedByTitle(std::move(child));
663 } 665 }
664 666
665 private: 667 private:
666 DISALLOW_COPY_AND_ASSIGN(CookieTreeCacheStoragesNode); 668 DISALLOW_COPY_AND_ASSIGN(CookieTreeCacheStoragesNode);
667 }; 669 };
668 670
669 // CookieTreeFlashLSONode ---------------------------------------------------- 671 // CookieTreeFlashLSONode ----------------------------------------------------
670 class CookieTreeFlashLSONode : public CookieTreeNode { 672 class CookieTreeFlashLSONode : public CookieTreeNode {
671 public: 673 public:
672 explicit CookieTreeFlashLSONode(const std::string& domain); 674 explicit CookieTreeFlashLSONode(const std::string& domain);
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
870 872
871 // Counts how many batches have started already. If this is non-zero and lower 873 // Counts how many batches have started already. If this is non-zero and lower
872 // than batches_ended_, then this model is still batching updates. 874 // than batches_ended_, then this model is still batching updates.
873 int batches_started_ = 0; 875 int batches_started_ = 0;
874 876
875 // Counts how many batches have finished. 877 // Counts how many batches have finished.
876 int batches_ended_ = 0; 878 int batches_ended_ = 0;
877 }; 879 };
878 880
879 #endif // CHROME_BROWSER_BROWSING_DATA_COOKIES_TREE_MODEL_H_ 881 #endif // CHROME_BROWSER_BROWSING_DATA_COOKIES_TREE_MODEL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698