Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: chrome/browser/android/bookmarks/partner_bookmarks_shim.cc

Issue 2379863002: Fix object ownership in ui/base/models. (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h" 5 #include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h"
6 6
7 #include <tuple> 7 #include <tuple>
8 8
9 #include "base/lazy_instance.h" 9 #include "base/lazy_instance.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 return true; 168 return true;
169 parent = parent->parent(); 169 parent = parent->parent();
170 } 170 }
171 return false; 171 return false;
172 } 172 }
173 173
174 const BookmarkNode* PartnerBookmarksShim::GetPartnerBookmarksRoot() const { 174 const BookmarkNode* PartnerBookmarksShim::GetPartnerBookmarksRoot() const {
175 return g_partner_model_keeper.Get().partner_bookmarks_root.get(); 175 return g_partner_model_keeper.Get().partner_bookmarks_root.get();
176 } 176 }
177 177
178 void PartnerBookmarksShim::SetPartnerBookmarksRoot(BookmarkNode* root_node) { 178 void PartnerBookmarksShim::SetPartnerBookmarksRoot(
179 std::unique_ptr<bookmarks::BookmarkNode> root_node) {
179 DCHECK_CURRENTLY_ON(BrowserThread::UI); 180 DCHECK_CURRENTLY_ON(BrowserThread::UI);
180 g_partner_model_keeper.Get().partner_bookmarks_root.reset(root_node); 181 g_partner_model_keeper.Get().partner_bookmarks_root = std::move(root_node);
181 g_partner_model_keeper.Get().loaded = true; 182 g_partner_model_keeper.Get().loaded = true;
182 FOR_EACH_OBSERVER(PartnerBookmarksShim::Observer, observers_, 183 FOR_EACH_OBSERVER(PartnerBookmarksShim::Observer, observers_,
183 PartnerShimLoaded(this)); 184 PartnerShimLoaded(this));
184 } 185 }
185 186
186 PartnerBookmarksShim::NodeRenamingMapKey::NodeRenamingMapKey( 187 PartnerBookmarksShim::NodeRenamingMapKey::NodeRenamingMapKey(
187 const GURL& url, const base::string16& provider_title) 188 const GURL& url, const base::string16& provider_title)
188 : url_(url), provider_title_(provider_title) {} 189 : url_(url), provider_title_(provider_title) {}
189 190
190 PartnerBookmarksShim::NodeRenamingMapKey::~NodeRenamingMapKey() {} 191 PartnerBookmarksShim::NodeRenamingMapKey::~NodeRenamingMapKey() {}
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 i != node_rename_remove_map_.end(); 283 i != node_rename_remove_map_.end();
283 ++i) { 284 ++i) {
284 base::DictionaryValue* dict = new base::DictionaryValue(); 285 base::DictionaryValue* dict = new base::DictionaryValue();
285 dict->SetString(kMappingUrl, i->first.url().spec()); 286 dict->SetString(kMappingUrl, i->first.url().spec());
286 dict->SetString(kMappingProviderTitle, i->first.provider_title()); 287 dict->SetString(kMappingProviderTitle, i->first.provider_title());
287 dict->SetString(kMappingTitle, i->second); 288 dict->SetString(kMappingTitle, i->second);
288 list.Append(dict); 289 list.Append(dict);
289 } 290 }
290 prefs_->Set(prefs::kPartnerBookmarkMappings, list); 291 prefs_->Set(prefs::kPartnerBookmarkMappings, list);
291 } 292 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698