Fix object ownership in ui/base/models.

chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/bookmarks/partner_bookmarks_shim.h"
 
 #include <stdint.h>
 
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/bookmarks/browser/bookmark_model.h"
 #include "components/bookmarks/test/bookmark_test_helpers.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/test/test_browser_thread.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gmock/include/gmock/gmock.h"
@@ skipping 62 matching lines @@
 
   BookmarkModel* model_;
   MockObserver observer_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PartnerBookmarksShimTest);
 };
 
 TEST_F(PartnerBookmarksShimTest, GetNodeByID) {
   BookmarkNode* root_partner_node = new BookmarkPermanentNode(0);
   BookmarkNode* partner_folder1 = new BookmarkNode(1, GURL());

[Bernhard Bauer, 2016/09/30 08:58:44]

Can we make this a unique_ptr<> as well?

[Avi (use Gerrit), 2016/09/30 16:10:12]

Done.

   partner_folder1->set_type(BookmarkNode::FOLDER);
-  root_partner_node->Add(partner_folder1, root_partner_node->child_count());
+  root_partner_node->Add(base::WrapUnique(partner_folder1),
+                         root_partner_node->child_count());
 
   BookmarkNode* partner_folder2 = new BookmarkNode(2, GURL());
   partner_folder2->set_type(BookmarkNode::FOLDER);
-  partner_folder1->Add(partner_folder2, partner_folder1->child_count());
+  partner_folder1->Add(base::WrapUnique(partner_folder2),
+                       partner_folder1->child_count());
 
   BookmarkNode* partner_bookmark1 = new BookmarkNode(3,
                                                      GURL("http://www.a.com"));
   partner_bookmark1->set_type(BookmarkNode::URL);
-  partner_folder1->Add(partner_bookmark1, partner_folder1->child_count());
+  partner_folder1->Add(base::WrapUnique(partner_bookmark1),
+                       partner_folder1->child_count());
 
   BookmarkNode* partner_bookmark2 = new BookmarkNode(4,
                                                      GURL("http://www.b.com"));
   partner_bookmark2->set_type(BookmarkNode::URL);
-  partner_folder2->Add(partner_bookmark2, partner_folder2->child_count());
+  partner_folder2->Add(base::WrapUnique(partner_bookmark2),
+                       partner_folder2->child_count());
 
   PartnerBookmarksShim* shim = partner_bookmarks_shim();
   ASSERT_FALSE(shim->IsLoaded());
   shim->SetPartnerBookmarksRoot(root_partner_node);

[Bernhard Bauer, 2016/09/30 08:58:43]

And make this method also take a unique_ptr<>?

[Avi (use Gerrit), 2016/09/30 16:10:12]

Done.

   ASSERT_TRUE(shim->IsLoaded());
 
   ASSERT_TRUE(shim->IsPartnerBookmark(root_partner_node));
   ASSERT_EQ(shim->GetNodeByID(0), root_partner_node);
   ASSERT_EQ(shim->GetNodeByID(1), partner_folder1);
   ASSERT_EQ(shim->GetNodeByID(4), partner_bookmark2);
 }
 
 TEST_F(PartnerBookmarksShimTest, ObserverNotifiedOfLoadNoPartnerBookmarks) {
   EXPECT_CALL(observer_, PartnerShimLoaded(_)).Times(0);
   PartnerBookmarksShim* shim = partner_bookmarks_shim();
   shim->AddObserver(&observer_);
 
   EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(1);
   shim->SetPartnerBookmarksRoot(NULL);
 }
 
 TEST_F(PartnerBookmarksShimTest, ObserverNotifiedOfLoadWithPartnerBookmarks) {
   EXPECT_CALL(observer_, PartnerShimLoaded(_)).Times(0);
   int64_t id = 5;
   BookmarkNode* root_partner_node = new BookmarkPermanentNode(id++);
   BookmarkNode* partner_bookmark1 = new BookmarkNode(id++,
                                                      GURL("http://www.a.com"));
   partner_bookmark1->set_type(BookmarkNode::URL);
-  root_partner_node->Add(partner_bookmark1, root_partner_node->child_count());
+  root_partner_node->Add(base::WrapUnique(partner_bookmark1),
+                         root_partner_node->child_count());
 
   PartnerBookmarksShim* shim = partner_bookmarks_shim();
   shim->AddObserver(&observer_);
 
   EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(1);
   shim->SetPartnerBookmarksRoot(root_partner_node);
 }
 
 TEST_F(PartnerBookmarksShimTest, RemoveBookmarks) {
   PartnerBookmarksShim* shim = partner_bookmarks_shim();
   shim->AddObserver(&observer_);
 
   EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(0);
   EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(0);
 
   BookmarkNode* root_partner_node = new BookmarkPermanentNode(0);
   root_partner_node->SetTitle(base::ASCIIToUTF16("Partner bookmarks"));
 
   BookmarkNode* partner_folder1 = new BookmarkNode(1, GURL("http://www.a.net"));
   partner_folder1->set_type(BookmarkNode::FOLDER);
-  root_partner_node->Add(partner_folder1, root_partner_node->child_count());
+  root_partner_node->Add(base::WrapUnique(partner_folder1),
+                         root_partner_node->child_count());
 
   BookmarkNode* partner_folder2 = new BookmarkNode(2, GURL("http://www.b.net"));
   partner_folder2->set_type(BookmarkNode::FOLDER);
-  root_partner_node->Add(partner_folder2, root_partner_node->child_count());
+  root_partner_node->Add(base::WrapUnique(partner_folder2),
+                         root_partner_node->child_count());
 
   BookmarkNode* partner_bookmark1 = new BookmarkNode(3,
                                                      GURL("http://www.a.com"));
   partner_bookmark1->set_type(BookmarkNode::URL);
-  partner_folder1->Add(partner_bookmark1, partner_folder1->child_count());
+  partner_folder1->Add(base::WrapUnique(partner_bookmark1),
+                       partner_folder1->child_count());
 
   BookmarkNode* partner_bookmark2 = new BookmarkNode(4,
                                                      GURL("http://www.b.com"));
   partner_bookmark2->set_type(BookmarkNode::URL);
-  partner_folder2->Add(partner_bookmark2, partner_folder2->child_count());
+  partner_folder2->Add(base::WrapUnique(partner_bookmark2),
+                       partner_folder2->child_count());
 
   BookmarkNode* partner_folder3 = new BookmarkNode(5, GURL("http://www.c.net"));
   partner_folder3->set_type(BookmarkNode::FOLDER);
-  partner_folder2->Add(partner_folder3, partner_folder2->child_count());
+  partner_folder2->Add(base::WrapUnique(partner_folder3),
+                       partner_folder2->child_count());
 
   BookmarkNode* partner_bookmark3 = new BookmarkNode(6,
                                                      GURL("http://www.c.com"));
   partner_bookmark3->set_type(BookmarkNode::URL);
-  partner_folder3->Add(partner_bookmark3, partner_folder3->child_count());
+  partner_folder3->Add(base::WrapUnique(partner_bookmark3),
+                       partner_folder3->child_count());
 
   ASSERT_FALSE(shim->IsLoaded());
   EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(1);
   shim->SetPartnerBookmarksRoot(root_partner_node);
   ASSERT_TRUE(shim->IsLoaded());
 
   EXPECT_EQ(root_partner_node, shim->GetNodeByID(0));
   EXPECT_EQ(partner_folder1, shim->GetNodeByID(1));
   EXPECT_EQ(partner_folder2, shim->GetNodeByID(2));
   EXPECT_EQ(partner_bookmark1, shim->GetNodeByID(3));
@@ skipping 46 matching lines @@
 
   EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(0);
   EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(0);
 
   BookmarkNode* root_partner_node = new BookmarkPermanentNode(0);
   root_partner_node->SetTitle(base::ASCIIToUTF16("Partner bookmarks"));
 
   BookmarkNode* partner_folder1 = new BookmarkNode(1, GURL("http://www.a.net"));
   partner_folder1->set_type(BookmarkNode::FOLDER);
   partner_folder1->SetTitle(base::ASCIIToUTF16("a.net"));
-  root_partner_node->Add(partner_folder1, root_partner_node->child_count());
+  root_partner_node->Add(base::WrapUnique(partner_folder1),
+                         root_partner_node->child_count());
 
   BookmarkNode* partner_folder2 = new BookmarkNode(2, GURL("http://www.b.net"));
   partner_folder2->set_type(BookmarkNode::FOLDER);
   partner_folder2->SetTitle(base::ASCIIToUTF16("b.net"));
-  root_partner_node->Add(partner_folder2, root_partner_node->child_count());
+  root_partner_node->Add(base::WrapUnique(partner_folder2),
+                         root_partner_node->child_count());
 
   BookmarkNode* partner_bookmark1 = new BookmarkNode(3,
                                                      GURL("http://www.a.com"));
   partner_bookmark1->set_type(BookmarkNode::URL);
   partner_bookmark1->SetTitle(base::ASCIIToUTF16("a.com"));
-  partner_folder1->Add(partner_bookmark1, partner_folder1->child_count());
+  partner_folder1->Add(base::WrapUnique(partner_bookmark1),
+                       partner_folder1->child_count());
 
   BookmarkNode* partner_bookmark2 = new BookmarkNode(4,
                                                      GURL("http://www.b.com"));
   partner_bookmark2->set_type(BookmarkNode::URL);
   partner_bookmark2->SetTitle(base::ASCIIToUTF16("b.com"));
-  partner_folder2->Add(partner_bookmark2, partner_folder2->child_count());
+  partner_folder2->Add(base::WrapUnique(partner_bookmark2),
+                       partner_folder2->child_count());
 
   ASSERT_FALSE(shim->IsLoaded());
   EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(1);
   shim->SetPartnerBookmarksRoot(root_partner_node);
   ASSERT_TRUE(shim->IsLoaded());
 
   EXPECT_EQ(root_partner_node, shim->GetNodeByID(0));
   EXPECT_EQ(partner_folder1, shim->GetNodeByID(1));
   EXPECT_EQ(partner_folder2, shim->GetNodeByID(2));
   EXPECT_EQ(partner_bookmark1, shim->GetNodeByID(3));
@@ skipping 47 matching lines @@
 
     EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(0);
     EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(0);
 
     BookmarkNode* root_partner_node = new BookmarkPermanentNode(0);
     root_partner_node->SetTitle(base::ASCIIToUTF16("Partner bookmarks"));
 
     BookmarkNode* partner_folder1 = new BookmarkNode(1, GURL("http://a.net"));
     partner_folder1->set_type(BookmarkNode::FOLDER);
     partner_folder1->SetTitle(base::ASCIIToUTF16("a.net"));
-    root_partner_node->Add(partner_folder1, root_partner_node->child_count());
+    root_partner_node->Add(base::WrapUnique(partner_folder1),
+                           root_partner_node->child_count());
 
     BookmarkNode* partner_bookmark1 = new BookmarkNode(3,
                                                        GURL("http://a.com"));
     partner_bookmark1->set_type(BookmarkNode::URL);
     partner_bookmark1->SetTitle(base::ASCIIToUTF16("a.com"));
-    partner_folder1->Add(partner_bookmark1, partner_folder1->child_count());
+    partner_folder1->Add(base::WrapUnique(partner_bookmark1),
+                         partner_folder1->child_count());
 
     BookmarkNode* partner_bookmark2 = new BookmarkNode(5,
                                                        GURL("http://b.com"));
     partner_bookmark2->set_type(BookmarkNode::URL);
     partner_bookmark2->SetTitle(base::ASCIIToUTF16("b.com"));
-    partner_folder1->Add(partner_bookmark2, partner_folder1->child_count());
+    partner_folder1->Add(base::WrapUnique(partner_bookmark2),
+                         partner_folder1->child_count());
 
     ASSERT_FALSE(shim->IsLoaded());
     EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(1);
     shim->SetPartnerBookmarksRoot(root_partner_node);
     ASSERT_TRUE(shim->IsLoaded());
 
     EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(2);
     shim->RenameBookmark(partner_bookmark1, base::ASCIIToUTF16("a2.com"));
     shim->RemoveBookmark(partner_bookmark2);
     EXPECT_EQ(base::ASCIIToUTF16("a2.com"), shim->GetTitle(partner_bookmark1));
@@ skipping 24 matching lines @@
 
   EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(0);
   EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(0);
 
   BookmarkNode* root_partner_node = new BookmarkPermanentNode(0);
   root_partner_node->SetTitle(base::ASCIIToUTF16("Partner bookmarks"));
 
   BookmarkNode* partner_bookmark1 = new BookmarkNode(3, GURL("http://a"));
   partner_bookmark1->set_type(BookmarkNode::URL);
   partner_bookmark1->SetTitle(base::ASCIIToUTF16("a"));
-  root_partner_node->Add(partner_bookmark1, root_partner_node->child_count());
+  root_partner_node->Add(base::WrapUnique(partner_bookmark1),
+                         root_partner_node->child_count());
 
   BookmarkNode* partner_bookmark2 = new BookmarkNode(3, GURL("http://b"));
   partner_bookmark2->set_type(BookmarkNode::URL);
   partner_bookmark2->SetTitle(base::ASCIIToUTF16("b"));
-  root_partner_node->Add(partner_bookmark2, root_partner_node->child_count());
+  root_partner_node->Add(base::WrapUnique(partner_bookmark2),
+                         root_partner_node->child_count());
 
   ASSERT_FALSE(shim->IsLoaded());
   EXPECT_CALL(observer_, PartnerShimLoaded(shim)).Times(1);
   shim->SetPartnerBookmarksRoot(root_partner_node);
   ASSERT_TRUE(shim->IsLoaded());
 
   // Check that edits work by default.
   EXPECT_CALL(observer_, PartnerShimChanged(shim)).Times(2);
   shim->RenameBookmark(partner_bookmark1, base::ASCIIToUTF16("a2.com"));
   shim->RemoveBookmark(partner_bookmark2);
   EXPECT_EQ(base::ASCIIToUTF16("a2.com"), shim->GetTitle(partner_bookmark1));
   EXPECT_FALSE(shim->IsReachable(partner_bookmark2));
 
   // Disable edits and check that edits are not applied anymore.
   PartnerBookmarksShim::DisablePartnerBookmarksEditing();
   EXPECT_EQ(base::ASCIIToUTF16("a"), shim->GetTitle(partner_bookmark1));
   EXPECT_TRUE(shim->IsReachable(partner_bookmark2));
 }