Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2379843002: Add SK_SUPPORT_LEGACY_HAIRLINE_END_CAP to work around dependent test failure. (Closed)

Created:
4 years, 2 months ago by dogben
Modified:
4 years, 2 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add SK_SUPPORT_LEGACY_HAIRLINE_END_CAP to work around dependent test failure. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2379843002 Committed: https://skia.googlesource.com/skia/+/aa6ef3ebc60e0f70db0e599f4cd34d5be06486c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M public.bzl View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkScan_Hairline.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dogben
I tried most of today to debug the failure, but I didn't get very far. ...
4 years, 2 months ago (2016-09-29 02:24:28 UTC) #7
caryclark
lgtm
4 years, 2 months ago (2016-09-29 12:21:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379843002/1
4 years, 2 months ago (2016-09-29 13:41:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/aa6ef3ebc60e0f70db0e599f4cd34d5be06486c9
4 years, 2 months ago (2016-09-29 13:42:55 UTC) #12
dogben
4 years, 2 months ago (2016-09-29 16:36:12 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2379993004/ by benjaminwagner@google.com.

The reason for reverting is: Dependent test has been fixed..

Powered by Google App Engine
This is Rietveld 408576698