Hookup the window.open flash download interception to the permission prompt

Hookup the window.open flash download interception to the permission prompt

This triggers a permission prompt when the flash download page is navigated to
in a new window.

BUG=641615
Committed: https://crrev.com/0e3944dae9fb18b92e2db0d6bdedb267c4584c3b
Cr-Commit-Position: refs/heads/master@{#422019}

[raymes, 2016-09-29 01:41:39]

raymes@chromium.org changed reviewers:
+ tommycli@chromium.org

[raymes, 2016-09-29 01:41:40]

Tommy, ptal. I'll also add a test for the prompt coming from here.

[raymes, 2016-09-29 04:06:57]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 04:07:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 04:24:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 04:24:04]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[raymes, 2016-09-29 04:40:12]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 04:40:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 05:20:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 05:20:02]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-09-29 16:40:02]

lgtm thank you!

[raymes, 2016-09-30 01:17:10]

raymes@chromium.org changed reviewers:
+ thestig@chromium.org

[raymes, 2016-09-30 01:17:10]

+thestig for chrome/browser

[Lei Zhang, 2016-09-30 01:22:46]

lgtm

https://codereview.chromium.org/2379833002/diff/20001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/2379833002/diff/20001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client.cc:629: void
HandleFlashDownloadActionOnUIThread(int render_process_id,
DCHECK_CURRENTLY_ON(...)

https://codereview.chromium.org/2379833002/diff/20001/chrome/browser/plugins/...
File chrome/browser/plugins/flash_download_interception.cc (right):

https://codereview.chromium.org/2379833002/diff/20001/chrome/browser/plugins/...
chrome/browser/plugins/flash_download_interception.cc:34: bool
InterceptNavigation(
Why bother returning true if that's what we always do? Are there plans to
eventually return false? Or is it just to make the rest of the code happy?

[raymes, 2016-09-30 01:53:13]

The CQ bit was checked by raymes@chromium.org

[raymes, 2016-09-30 01:53:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2379833002/#ps40001
(title: "Hookup the window.open flash download interception to the permission
prompt")

[raymes, 2016-09-30 01:53:19]

https://codereview.chromium.org/2379833002/diff/20001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/2379833002/diff/20001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client.cc:629: void
HandleFlashDownloadActionOnUIThread(int render_process_id,
On 2016/09/30 01:22:46, Lei Zhang wrote:
> DCHECK_CURRENTLY_ON(...)

Done.

https://codereview.chromium.org/2379833002/diff/20001/chrome/browser/plugins/...
File chrome/browser/plugins/flash_download_interception.cc (right):

https://codereview.chromium.org/2379833002/diff/20001/chrome/browser/plugins/...
chrome/browser/plugins/flash_download_interception.cc:34: bool
InterceptNavigation(
On 2016/09/30 01:22:46, Lei Zhang wrote:
> Why bother returning true if that's what we always do? Are there plans to
> eventually return false? Or is it just to make the rest of the code happy?

Just to make the code happy - the callback needs to have it I think.

[commit-bot: I haz the power, 2016-09-30 01:53:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 03:13:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-30 03:15:41]

Description was changed from

==========
Hookup the window.open flash download interception to the permission prompt

This triggers a permission prompt when the flash download page is navigated to
in a new window.

BUG=641615
==========

to

==========
Hookup the window.open flash download interception to the permission prompt

This triggers a permission prompt when the flash download page is navigated to
in a new window.

BUG=641615

Committed: https://crrev.com/0e3944dae9fb18b92e2db0d6bdedb267c4584c3b
Cr-Commit-Position: refs/heads/master@{#422019}
==========

[commit-bot: I haz the power, 2016-09-30 03:15:42]

Patchset 3 (id:??) landed as
https://crrev.com/0e3944dae9fb18b92e2db0d6bdedb267c4584c3b
Cr-Commit-Position: refs/heads/master@{#422019}