Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1273)

Unified Diff: third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h

Issue 2379823003: Move MHTML file writing out of the renderer main thread. (Closed)
Patch Set: A few move semantics fixes (I think). Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h
diff --git a/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h b/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h
index a73d816a9b847939191420e732d80bae70a49141..5591b99c765a75a3c4b2e1c4fa74bc686bc3788c 100644
--- a/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h
+++ b/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.h
@@ -35,6 +35,7 @@
#include "wtf/HashMap.h"
#include "wtf/Vector.h"
#include "wtf/text/StringHash.h"
+#include <vector>
namespace blink {
@@ -61,7 +62,7 @@ public:
// MHTML document (see also rfc1341, section 7.2.1, "boundary" description).
static void generateMHTMLHeader(
const String& boundary, const String& title, const String& mimeType,
- SharedBuffer& outputBuffer);
+ std::vector<char>& outputBuffer);
carlosk 2016/10/03 23:51:05 Is it really OK to pass non const references in Bl
carlosk 2016/10/04 21:49:53 Just for the record: I did ask dcheng@ directly ab
// Serializes SerializedResource as an MHTML part and appends it in
// |outputBuffer|.
@@ -75,7 +76,7 @@ public:
static void generateMHTMLPart(
const String& boundary, const String& contentID,
EncodingPolicy, const SerializedResource&,
- SharedBuffer& outputBuffer);
+ std::vector<char>& outputBuffer);
// Generates an MHTML footer and appends it to |outputBuffer|.
//
@@ -84,7 +85,7 @@ public:
// MHTML document (see also rfc1341, section 7.2.1, "boundary" description).
static void generateMHTMLFooter(
const String& boundary,
- SharedBuffer& outputBuffer);
+ std::vector<char>& outputBuffer);
typedef HeapHashMap<String, Member<ArchiveResource>> SubArchiveResources;

Powered by Google App Engine
This is Rietveld 408576698