Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2379803003: CSS backdrop-filter other than 'none' should force stacking context. (Closed)
Patch Set: rebased & update expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org) 2 * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
4 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 4 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 1141 matching lines...) Expand 10 before | Expand all | Expand 10 after
1152 } 1152 }
1153 1153
1154 void ComputedStyle::updateIsStackingContext(bool isDocumentElement, 1154 void ComputedStyle::updateIsStackingContext(bool isDocumentElement,
1155 bool isInTopLayer) { 1155 bool isInTopLayer) {
1156 if (isStackingContext()) 1156 if (isStackingContext())
1157 return; 1157 return;
1158 1158
1159 if (isDocumentElement || isInTopLayer || styleType() == PseudoIdBackdrop || 1159 if (isDocumentElement || isInTopLayer || styleType() == PseudoIdBackdrop ||
1160 hasOpacity() || hasTransformRelatedProperty() || hasMask() || 1160 hasOpacity() || hasTransformRelatedProperty() || hasMask() ||
1161 clipPath() || boxReflect() || hasFilterInducingProperty() || 1161 clipPath() || boxReflect() || hasFilterInducingProperty() ||
1162 hasBlendMode() || hasIsolation() || hasViewportConstrainedPosition() || 1162 hasBackdropFilter() || hasBlendMode() || hasIsolation() ||
1163 hasViewportConstrainedPosition() ||
1163 hasPropertyThatCreatesStackingContext(willChangeProperties()) || 1164 hasPropertyThatCreatesStackingContext(willChangeProperties()) ||
1164 containsPaint()) { 1165 containsPaint()) {
1165 setIsStackingContext(true); 1166 setIsStackingContext(true);
1166 } 1167 }
1167 } 1168 }
1168 1169
1169 void ComputedStyle::addCallbackSelector(const String& selector) { 1170 void ComputedStyle::addCallbackSelector(const String& selector) {
1170 if (!m_rareNonInheritedData->m_callbackSelectors.contains(selector)) 1171 if (!m_rareNonInheritedData->m_callbackSelectors.contains(selector))
1171 m_rareNonInheritedData.access()->m_callbackSelectors.append(selector); 1172 m_rareNonInheritedData.access()->m_callbackSelectors.append(selector);
1172 } 1173 }
(...skipping 1137 matching lines...) Expand 10 before | Expand all | Expand 10 after
2310 if (value < 0) 2311 if (value < 0)
2311 fvalue -= 0.5f; 2312 fvalue -= 0.5f;
2312 else 2313 else
2313 fvalue += 0.5f; 2314 fvalue += 0.5f;
2314 } 2315 }
2315 2316
2316 return roundForImpreciseConversion<int>(fvalue / zoomFactor); 2317 return roundForImpreciseConversion<int>(fvalue / zoomFactor);
2317 } 2318 }
2318 2319
2319 } // namespace blink 2320 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698