Linux create_sdk GN build for host

Linux create_sdk GN build for host

This CL enables GN builds of all targets from dart.gyp
on Linux for the host (i.e. ia32, x64).

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/7c784cea9f91a40d66350ed4b08e0422a25ba0ad

[zra, 2016-09-29 16:17:51]

Description was changed from

==========
Start work on create_sdk GN build
==========

to

==========
Linux create_sdk GN build for host

This CL enables GN builds of all targets from dart.gyp
on Linux for the host (i.e. ia32, x64).
==========

[zra, 2016-09-29 16:18:10]

zra@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-09-29 16:41:26]

https://codereview.chromium.org/2379803002/diff/60001/pkg/BUILD.gn
File pkg/BUILD.gn (right):

https://codereview.chromium.org/2379803002/diff/60001/pkg/BUILD.gn#newcode5
pkg/BUILD.gn:5: template("make_third_party_pkg_files_stamp") {
Could this be factored into a template that is shared between this file and
utils/compiler/BUILD.gn ?

https://codereview.chromium.org/2379803002/diff/60001/utils/invoke_dart.gni
File utils/invoke_dart.gni (right):

https://codereview.chromium.org/2379803002/diff/60001/utils/invoke_dart.gni#n...
utils/invoke_dart.gni:8: dart_root = invoker.dart_root
can't we automatically detect the dart root from the path of this gni file? Use
rebase path to get the absolute path of this file and then it's just ../ from
there.

[zra, 2016-09-29 17:46:41]

https://codereview.chromium.org/2379803002/diff/60001/pkg/BUILD.gn
File pkg/BUILD.gn (right):

https://codereview.chromium.org/2379803002/diff/60001/pkg/BUILD.gn#newcode5
pkg/BUILD.gn:5: template("make_third_party_pkg_files_stamp") {
On 2016/09/29 16:41:26, Cutch wrote:
> Could this be factored into a template that is shared between this file and
> utils/compiler/BUILD.gn ?

Done.

https://codereview.chromium.org/2379803002/diff/60001/utils/invoke_dart.gni
File utils/invoke_dart.gni (right):

https://codereview.chromium.org/2379803002/diff/60001/utils/invoke_dart.gni#n...
utils/invoke_dart.gni:8: dart_root = invoker.dart_root
On 2016/09/29 16:41:26, Cutch wrote:
> can't we automatically detect the dart root from the path of this gni file?
Use
> rebase path to get the absolute path of this file and then it's just ../ from
> there.

Done.

[Cutch, 2016-09-29 20:04:08]

LGTM with a suggestion to move a file

https://codereview.chromium.org/2379803002/diff/80001/utils/compiler/BUILD.gn
File utils/compiler/BUILD.gn (right):

https://codereview.chromium.org/2379803002/diff/80001/utils/compiler/BUILD.gn...
utils/compiler/BUILD.gn:6: import("../../pkg/create_timestamp.gni")
maybe create_timestamp.gni should be moved to utils/ instead of pkg/?

[zra, 2016-09-29 20:22:48]

https://codereview.chromium.org/2379803002/diff/80001/utils/compiler/BUILD.gn
File utils/compiler/BUILD.gn (right):

https://codereview.chromium.org/2379803002/diff/80001/utils/compiler/BUILD.gn...
utils/compiler/BUILD.gn:6: import("../../pkg/create_timestamp.gni")
On 2016/09/29 20:04:08, Cutch wrote:
> maybe create_timestamp.gni should be moved to utils/ instead of pkg/?

Done.

[zra, 2016-09-29 20:23:03]

Description was changed from

==========
Linux create_sdk GN build for host

This CL enables GN builds of all targets from dart.gyp
on Linux for the host (i.e. ia32, x64).
==========

to

==========
Linux create_sdk GN build for host

This CL enables GN builds of all targets from dart.gyp
on Linux for the host (i.e. ia32, x64).

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7c784cea9f91a40d66350ed4b08e0422a25ba0ad
==========

[zra, 2016-09-29 20:23:04]

Committed patchset #6 (id:90001) manually as
7c784cea9f91a40d66350ed4b08e0422a25ba0ad (presubmit successful).