Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2379783003: [omnibox] Return reference to ImageView instead of LocationIconView (2) (Closed)

Created:
4 years, 2 months ago by Kevin Bailey
Modified:
4 years, 2 months ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[omnibox] Return reference to ImageView instead of LocationIconView (2) Found another place where we need to return a reference to the ImageView, not the LocationIconView. From the previous CL: The latter is quite wide when we fill in the label half of it, which we now do with site security level in some cases. The bubble (in the bug that is in the wrong place) anchors to the middle of whatever View you return to it, so we really want to give it the padlock here. BUG=650140 Committed: https://crrev.com/b34fa9422ed84323d7d20ebc9eb69bb946207e87 Cr-Commit-Position: refs/heads/master@{#422094}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Kevin Bailey
On 2016/09/29 15:10:04, Kevin Bailey wrote: > mailto:krb@chromium.org changed reviewers: > + mailto:benwells@chromium.org Hi Ben, ...
4 years, 2 months ago (2016-09-29 15:12:21 UTC) #3
Kevin Bailey
On 2016/09/29 15:12:21, Kevin Bailey wrote: > On 2016/09/29 15:10:04, Kevin Bailey wrote: > > ...
4 years, 2 months ago (2016-09-29 15:16:49 UTC) #4
benwells
lgtm
4 years, 2 months ago (2016-09-30 01:21:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379783003/1
4 years, 2 months ago (2016-09-30 13:09:35 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 13:14:54 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 13:17:42 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b34fa9422ed84323d7d20ebc9eb69bb946207e87
Cr-Commit-Position: refs/heads/master@{#422094}

Powered by Google App Engine
This is Rietveld 408576698