Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: extensions/common/permissions/permissions_info.h

Issue 2379763003: Extract permission alias info from PermissionsProvider (Closed)
Patch Set: not nesting Alias in AliasProvider Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/permissions_info.h
diff --git a/extensions/common/permissions/permissions_info.h b/extensions/common/permissions/permissions_info.h
index 8f407de35ec7f520cb4b15b59811867eab813f36..b647023a3580dba729dd7c9fba2e72a3942aba1c 100644
--- a/extensions/common/permissions/permissions_info.h
+++ b/extensions/common/permissions/permissions_info.h
@@ -15,12 +15,15 @@
#include "base/callback.h"
#include "base/lazy_instance.h"
#include "base/macros.h"
+#include "extensions/common/alias_provider.h"
#include "extensions/common/permissions/api_permission.h"
#include "extensions/common/permissions/api_permission_set.h"
#include "extensions/common/permissions/permissions_provider.h"
namespace extensions {
+class Alias;
+
// A global object that holds the extension permission instances and provides
// methods for accessing them.
class PermissionsInfo {
@@ -28,7 +31,8 @@ class PermissionsInfo {
static PermissionsInfo* GetInstance();
// Initializes the permissions from the provider.
- void AddProvider(const PermissionsProvider& provider);
+ void AddProvider(const PermissionsProvider& permission_provider,
+ const AliasProvider& alias_provider);
// Returns the permission with the given |id|, and NULL if it doesn't exist.
const APIPermissionInfo* GetByID(APIPermission::ID id) const;
@@ -59,7 +63,7 @@ class PermissionsInfo {
virtual ~PermissionsInfo();
// Registers an |alias| for a given permission |name|.
- void RegisterAlias(const char* name, const char* alias);
+ void RegisterAlias(const Alias& alias);
// Registers a permission with the specified attributes and flags.
void RegisterPermission(std::unique_ptr<APIPermissionInfo> permission);

Powered by Google App Engine
This is Rietveld 408576698