Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: extensions/common/alias_provider.h

Issue 2379763003: Extract permission alias info from PermissionsProvider (Closed)
Patch Set: not nesting Alias in AliasProvider Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/alias_provider.h
diff --git a/extensions/common/alias_provider.h b/extensions/common/alias_provider.h
new file mode 100644
index 0000000000000000000000000000000000000000..dc7c89104fd1aca8a41ec4cb34abef33ba304645
--- /dev/null
+++ b/extensions/common/alias_provider.h
@@ -0,0 +1,47 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_COMMON_ALIAS_PROVIDER_H_
+#define EXTENSIONS_COMMON_ALIAS_PROVIDER_H_
+
+#include <string>
+#include <vector>
+
+#include "base/macros.h"
+#include "extensions/common/alias.h"
+
+namespace extensions {
+
+// TODO(tbarzic): Consider auto-generating these from a JSON schema file
+// (similar to what is done for features).
+class AliasProvider {
+ public:
+ AliasProvider();
+ virtual ~AliasProvider();
+
+ // Returns all valid API aliases provided by |this|.
+ std::vector<Alias> GetValidApiAliases() const;
+ // Returns all valid API aliases provided by |this|.
+ std::vector<Alias> GetValidPermissionAliases() const;
+
+ protected:
+ // Returns API aliases provided by |this|. Returned list may contain invalid
+ // aliases - they will be filtered out before further usage.
+ virtual std::vector<Alias> GetApiAliases() const = 0;
Devlin 2016/09/29 22:03:43 Until we use ApiAliases, I'd like to hold off on a
+ // Returns API aliases provided by |this|. Returned list may contain invalid
+ // aliases - they will be filtered out before further usage.
+ virtual std::vector<Alias> GetPermissionAliases() const = 0;
+
+ private:
+ // Returns |aliases| with invalid aliases filtered out.
+ std::vector<Alias> FilterOutInvalidAliases(
+ const std::vector<Alias>& aliases) const;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(AliasProvider);
+};
+
+} // namespace extensions
+
+#endif // EXTENSIONS_COMMON_ALIAS_PROVIDER_H_

Powered by Google App Engine
This is Rietveld 408576698