Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: extensions/common/permissions/extensions_api_permissions.cc

Issue 2379763003: Extract permission alias info from PermissionsProvider (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/permissions/extensions_api_permissions.h" 5 #include "extensions/common/permissions/extensions_api_permissions.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "extensions/common/permissions/api_permission.h" 12 #include "extensions/common/permissions/api_permission.h"
13 #include "extensions/common/permissions/socket_permission.h" 13 #include "extensions/common/permissions/socket_permission.h"
14 #include "extensions/common/permissions/usb_device_permission.h" 14 #include "extensions/common/permissions/usb_device_permission.h"
15 #include "grit/extensions_strings.h" 15 #include "grit/extensions_strings.h"
16 16
17 namespace extensions { 17 namespace extensions {
18 18
19 namespace { 19 namespace {
20 20
21 const char kOldAlwaysOnTopWindowsPermission[] = "alwaysOnTopWindows";
22 const char kOldFullscreenPermission[] = "fullscreen";
23 const char kOldOverrideEscFullscreenPermission[] = "overrideEscFullscreen";
24 const char kOldUnlimitedStoragePermission[] = "unlimited_storage";
25
26 template <typename T> 21 template <typename T>
27 APIPermission* CreateAPIPermission(const APIPermissionInfo* permission) { 22 APIPermission* CreateAPIPermission(const APIPermissionInfo* permission) {
28 return new T(permission); 23 return new T(permission);
29 } 24 }
30 25
31 } // namespace 26 } // namespace
32 27
33 std::vector<std::unique_ptr<APIPermissionInfo>> 28 std::vector<std::unique_ptr<APIPermissionInfo>>
34 ExtensionsAPIPermissions::GetAllPermissions() const { 29 ExtensionsAPIPermissions::GetAllPermissions() const {
35 // WARNING: If you are modifying a permission message in this list, be sure to 30 // WARNING: If you are modifying a permission message in this list, be sure to
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 }; 114 };
120 115
121 std::vector<std::unique_ptr<APIPermissionInfo>> permissions; 116 std::vector<std::unique_ptr<APIPermissionInfo>> permissions;
122 117
123 for (size_t i = 0; i < arraysize(permissions_to_register); ++i) 118 for (size_t i = 0; i < arraysize(permissions_to_register); ++i)
124 permissions.push_back( 119 permissions.push_back(
125 base::WrapUnique(new APIPermissionInfo(permissions_to_register[i]))); 120 base::WrapUnique(new APIPermissionInfo(permissions_to_register[i])));
126 return permissions; 121 return permissions;
127 } 122 }
128 123
129 std::vector<PermissionsProvider::AliasInfo>
130 ExtensionsAPIPermissions::GetAllAliases() const {
131 std::vector<PermissionsProvider::AliasInfo> aliases;
132 aliases.push_back(PermissionsProvider::AliasInfo(
133 "app.window.alwaysOnTop", kOldAlwaysOnTopWindowsPermission));
134 aliases.push_back(PermissionsProvider::AliasInfo("app.window.fullscreen",
135 kOldFullscreenPermission));
136 aliases.push_back(
137 PermissionsProvider::AliasInfo("app.window.fullscreen.overrideEsc",
138 kOldOverrideEscFullscreenPermission));
139 aliases.push_back(PermissionsProvider::AliasInfo(
140 "unlimitedStorage", kOldUnlimitedStoragePermission));
141 return aliases;
142 }
143
144 } // namespace extensions 124 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/common/permissions/extensions_api_permissions.h ('k') | extensions/common/permissions/permissions_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698