Add generate_jni template

Add generate_jni template

This adds a template for using the jni_generator. Creates the
base_jni_headers target and updates the base target to depend on it and
actually use the sources that required it.

Adds //third_party/android_tools:cpu_features required by one of the
base files that also required jni.

Disable a bunch of third_party targets for Android builds.

BUG=359249
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264695

[cjhopman, 2014-04-15 00:44:07]

brettw: *

I figured I should get jni stuff working because it's probably the big thing
blocking support for most of the native libraries for android builds.

https://codereview.chromium.org/237973002/diff/40001/tools/gn/secondary/third...
File tools/gn/secondary/third_party/leveldatabase/BUILD.gn (right):

https://codereview.chromium.org/237973002/diff/40001/tools/gn/secondary/third...
tools/gn/secondary/third_party/leveldatabase/BUILD.gn:131: if (!is_android) {
I don't like that we require this (and I may have more aggressively disabled
than required). I think that this should basically be enabled/disabled in
//BUILD.gn. That is, the generated default "all" target should only be those
targets listed in //:root rather than every single target.

https://codereview.chromium.org/237973002/diff/40001/tools/gn/secondary/third...
tools/gn/secondary/third_party/leveldatabase/BUILD.gn:131: if (!is_android) {
Thinking about this some more, I've changed my mind and I actually like
explicitly disabling the targets here better, it's less magic.

[cjhopman, 2014-04-15 00:45:27]

https://codereview.chromium.org/237973002/diff/40001/build/config/android/rul...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/237973002/diff/40001/build/config/android/rul...
build/config/android/rules.gni:1: # Declare a jni target
It would be really neat if this help could be surfaced in 'gn help'. 
http://crbug.com/363452

[brettw, 2014-04-15 20:50:25]

LGTM, exciting!

https://codereview.chromium.org/237973002/diff/40001/build/config/android/rul...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/237973002/diff/40001/build/config/android/rul...
build/config/android/rules.gni:3: # This target generates the native jni
bindings for a set of .java files.
Con't forget copyright for this file.

https://codereview.chromium.org/237973002/diff/40001/build/config/android/rul...
build/config/android/rules.gni:28: jni_generator_includes =
rebase_path("//base/android/jni_generator/jni_generator_helper.h")
I'd put rebase_path on the next line to avoid the long line.

https://codereview.chromium.org/237973002/diff/40001/tools/gn/secondary/third...
File tools/gn/secondary/third_party/android_tools/BUILD.gn (right):

https://codereview.chromium.org/237973002/diff/40001/tools/gn/secondary/third...
tools/gn/secondary/third_party/android_tools/BUILD.gn:1: 
Copyright.

https://codereview.chromium.org/237973002/diff/40001/tools/gn/secondary/third...
tools/gn/secondary/third_party/android_tools/BUILD.gn:3: include_dirs =
["ndk/sources/android/cpufeatures"]
Spaces inside [ ], same below

https://codereview.chromium.org/237973002/diff/40001/tools/gn/secondary/third...
tools/gn/secondary/third_party/android_tools/BUILD.gn:6:
static_library("cpu_features") {
static_library -> source_set

[cjhopman, 2014-04-17 17:57:03]

https://codereview.chromium.org/237973002/diff/40001/build/config/android/rul...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/237973002/diff/40001/build/config/android/rul...
build/config/android/rules.gni:3: # This target generates the native jni
bindings for a set of .java files.
On 2014/04/15 20:50:26, brettw wrote:
> Con't forget copyright for this file.

Done.

https://codereview.chromium.org/237973002/diff/40001/build/config/android/rul...
build/config/android/rules.gni:28: jni_generator_includes =
rebase_path("//base/android/jni_generator/jni_generator_helper.h")
On 2014/04/15 20:50:26, brettw wrote:
> I'd put rebase_path on the next line to avoid the long line.

Done.

https://codereview.chromium.org/237973002/diff/40001/tools/gn/secondary/third...
File tools/gn/secondary/third_party/android_tools/BUILD.gn (right):

https://codereview.chromium.org/237973002/diff/40001/tools/gn/secondary/third...
tools/gn/secondary/third_party/android_tools/BUILD.gn:1: 
On 2014/04/15 20:50:26, brettw wrote:
> Copyright.

Done.

https://codereview.chromium.org/237973002/diff/40001/tools/gn/secondary/third...
tools/gn/secondary/third_party/android_tools/BUILD.gn:3: include_dirs =
["ndk/sources/android/cpufeatures"]
On 2014/04/15 20:50:26, brettw wrote:
> Spaces inside [ ], same below

Done.

https://codereview.chromium.org/237973002/diff/40001/tools/gn/secondary/third...
tools/gn/secondary/third_party/android_tools/BUILD.gn:6:
static_library("cpu_features") {
On 2014/04/15 20:50:26, brettw wrote:
> static_library -> source_set

Done.

[cjhopman, 2014-04-17 17:57:06]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-04-17 17:57:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/237973002/60001

[commit-bot: I haz the power, 2014-04-17 17:58:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-17 17:58:04]

Failed to apply patch for base/BUILD.gn:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file base/BUILD.gn
  Hunk #2 succeeded at 17 (offset 1 line).
  Hunk #3 succeeded at 44 (offset 1 line).
  Hunk #4 succeeded at 691 (offset 1 line).
  Hunk #5 FAILED at 716.
  Hunk #6 succeeded at 901 (offset -9 lines).
  1 out of 6 hunks FAILED -- saving rejects to file base/BUILD.gn.rej

Patch:       base/BUILD.gn
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index
4da113c24a6a8cc43b6f7a6f37556b586da6e0e4..b58e86a49ec470132cb86dc6d1a7d165ddb1e5b4
100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -3,6 +3,7 @@
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
+import("//build/config/android/rules.gni")
 
 component("base") {
   sources = [
@@ -15,12 +16,16 @@ component("base") {
     "allocator/allocator_extension.h",
     "allocator/type_profiler_control.cc",
     "allocator/type_profiler_control.h",
-    "android/activity_status.cc",
-    "android/activity_status.h",
+    "android/application_status_listener.cc",
+    "android/application_status_listener.h",
     "android/base_jni_registrar.cc",
     "android/base_jni_registrar.h",
     "android/build_info.cc",
     "android/build_info.h",
+    "android/command_line_android.cc",
+    "android/command_line_android.h",
+    "android/content_uri_utils.cc",
+    "android/content_uri_utils.h",
     "android/cpu_features.cc",
     "android/fifo_utils.cc",
     "android/fifo_utils.h",
@@ -38,8 +43,12 @@ component("base") {
     "android/jni_registrar.h",
     "android/jni_string.cc",
     "android/jni_string.h",
+    "android/library_loader/library_loader_hooks.cc",
+    "android/library_loader/library_loader_hooks.h",
     "android/memory_pressure_listener_android.cc",
     "android/memory_pressure_listener_android.h",
+    "android/java_handler_thread.cc",
+    "android/java_handler_thread.h",
     "android/path_service_android.cc",
     "android/path_service_android.h",
     "android/path_utils.cc",
@@ -681,32 +690,6 @@ component("base") {
     "win/wrapped_window_proc.h",
   ]
 
-  if (is_android) {
-    sources -= [
-      "debug/stack_trace_posix.cc",
-    ]
-
-    # TODO(dpranke): crbug.com/360936.
-    # These are disabled until we have JNI support on Android.
-    sources -= [
-      "android/activity_status.cc",
-      "android/base_jni_registrar.cc",
-      "android/base_jni_registrar.h",
-      "android/build_info.cc",
-      "android/build_info.h",
-      "android/cpu_features.cc",
-      "android/important_file_writer_android.cc",
-      "android/memory_pressure_listener_android.cc",
-      "android/path_service_android.cc",
-      "android/path_utils.cc",
-      "android/sys_utils.cc",
-      "android/trace_event_binding.cc",
-      "message_loop/message_pump_android.cc",
-      "power_monitor/power_monitor_device_source_android.cc",
-      "threading/platform_thread_android.cc",
-    ]
-  }
-
   # TODO(brettw) I don't understand the conditions this file is used.
   sources -= [ "files/file_path_watcher_stub.cc" ]
 
@@ -733,6 +716,17 @@ component("base") {
     "//third_party/modp_b64",
   ]
 
+  if (is_android) {
+    deps += [
+      ":base_jni_headers",
+      "//third_party/android_tools:cpu_features"
+    ]
+
+    sources -= [
+      "debug/stack_trace_posix.cc",
+    ]
+  }
+
   if (!is_chromeos) {
     sources -= [
       "sys_info_chromeos.cc",
@@ -927,3 +921,27 @@ component("i18n") {
   #  'optimize': 'max',
   #},
 }
+
+if (is_android) {
+  generate_jni("base_jni_headers") {
+    sources = [
+      "android/java/src/org/chromium/base/ApplicationStatus.java",
+      "android/java/src/org/chromium/base/BuildInfo.java",
+      "android/java/src/org/chromium/base/CommandLine.java",
+      "android/java/src/org/chromium/base/ContentUriUtils.java",
+      "android/java/src/org/chromium/base/CpuFeatures.java",
+      "android/java/src/org/chromium/base/ImportantFileWriterAndroid.java",
+      "android/java/src/org/chromium/base/library_loader/LibraryLoader.java",
+      "android/java/src/org/chromium/base/MemoryPressureListener.java",
+      "android/java/src/org/chromium/base/JavaHandlerThread.java",
+      "android/java/src/org/chromium/base/PathService.java",
+      "android/java/src/org/chromium/base/PathUtils.java",
+      "android/java/src/org/chromium/base/PowerMonitor.java",
+      "android/java/src/org/chromium/base/SystemMessageHandler.java",
+      "android/java/src/org/chromium/base/SysUtils.java",
+      "android/java/src/org/chromium/base/ThreadUtils.java",
+      "android/java/src/org/chromium/base/TraceEvent.java",
+    ]
+    jni_package = "base"
+  }
+}

[cjhopman, 2014-04-17 21:29:34]

Rebase required:

disable //net and //crypto on Android
add cpu_features dependency to libwebp_dsp

[cjhopman, 2014-04-17 21:29:43]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-04-17 21:30:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/237973002/80001

[commit-bot: I haz the power, 2014-04-18 00:50:14]

Change committed as 264695