Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: third_party/WebKit/public/platform/modules/presentation/presentation.mojom

Issue 2379703002: [Presentation API] (alternative) 1-UA: send message between controller and receiver page (Closed)
Patch Set: resolve code review comments from Mark Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/presentation/presentation.mojom
diff --git a/third_party/WebKit/public/platform/modules/presentation/presentation.mojom b/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
index 0427db2c60e7d0709b13a1b4b2bbbeea73563084..2cec650cc8a4d2cd02740072b4f42795bba9ec26 100644
--- a/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
+++ b/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
@@ -52,6 +52,16 @@ struct SessionMessage {
array<uint8>? data;
};
+interface PresentationConnection {
+ // Called to set the PresentationConnection interface that sends
mark a. foltz 2016/10/10 18:28:52 Called to set the PresentationConnection that is t
zhaobin 2016/10/12 02:27:34 Done.
+ // messages in the opposite direction.
+ SetTargetConnection(PresentationConnection connection);
+
+ // Called when connection.send() is invoked at the other end of the
mark a. foltz 2016/10/10 18:28:52 Called when a message is sent by the target connec
zhaobin 2016/10/12 02:27:34 Done.
+ // connection.
+ OnSessionMessageReceived(SessionMessage message);
mark a. foltz 2016/10/10 18:28:52 OnConnectionMessageReceived (we'll rename the para
zhaobin 2016/10/12 02:27:34 Done.
+};
+
interface PresentationService {
// Sets the PresentationServiceClient.
SetClient(PresentationServiceClient client);
@@ -109,6 +119,9 @@ interface PresentationService {
// PresentationServiceClient::OnSessionMessagesReceived.
// This is called after a presentation session is created.
ListenForSessionMessages(PresentationSessionInfo sessionInfo);
+
+ SetPresentationConnection(PresentationSessionInfo sessionInfo,
+ PresentationConnection connection);
};
interface PresentationServiceClient {
@@ -143,5 +156,6 @@ interface PresentationServiceClient {
OnDefaultSessionStarted(PresentationSessionInfo sessionInfo);
// See PresentationService::ListeningForReceiverPageRendered.
mark a. foltz 2016/10/10 18:28:53 Can you describe the meaning of this here? e.g.
zhaobin 2016/10/12 02:27:34 Done.
- OnReceiverConnectionAvailable(PresentationSessionInfo sessionInfo);
+ OnReceiverConnectionAvailable(PresentationSessionInfo sessionInfo,
+ PresentationConnection connection);
};

Powered by Google App Engine
This is Rietveld 408576698