extensions/renderer/resources/media_router_bindings.js - Issue 2379703002: [Presentation API] (alternative) 1-UA: send message between controller and receiver page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/media_router_bindings.js

Issue 2379703002: [Presentation API] (alternative) 1-UA: send message between controller and receiver page (Closed)

Patch Set: resolve code review comments from Mark Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/resources/media_router_bindings.js

diff --git a/extensions/renderer/resources/media_router_bindings.js b/extensions/renderer/resources/media_router_bindings.js

index dd1ffdec7f53143fc6642ab31dd8f13f582eadd9..6538911645b67a61894ac0c31237635aa6dc49e4 100644

--- a/extensions/renderer/resources/media_router_bindings.js

+++ b/extensions/renderer/resources/media_router_bindings.js

@@ -80,7 +80,8 @@ define('media_router_bindings', [

// Begin newly added properties, followed by the milestone they were

// added. The guard should be safe to remove N+2 milestones later.

'for_display': route.forDisplay, // M47

- 'incognito': !!route.offTheRecord // M50

+ 'incognito': !!route.offTheRecord, // M50

+ 'is_offscreen_presentation': !!route.isOffscreenPresentation // M56

});

}