[Presentation API] (alternative) 1-UA: send message between controller and receiver page

third_party/WebKit/public/platform/modules/presentation/presentation.mojom

Index: third_party/WebKit/public/platform/modules/presentation/presentation.mojom
diff --git a/third_party/WebKit/public/platform/modules/presentation/presentation.mojom b/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
index 0427db2c60e7d0709b13a1b4b2bbbeea73563084..260f31fa67ccbfae1d14af3fdaf9f9005464148a 100644
--- a/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
+++ b/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
@@ -11,6 +11,7 @@ import "url/mojo/url.mojom";
 struct PresentationSessionInfo {
   url.mojom.Url url;
   string id;
+  bool is_offscreen_presentation;

[mark a. foltz, 2016/10/21 00:53:03]

Or just is_offscreen?  Since it's part of PresentationSessionInfo.

[zhaobin, 2016/10/22 02:44:14]

Done.

 };
 
 enum PresentationConnectionState {
@@ -52,6 +53,15 @@ struct SessionMessage {
   array<uint8>? data;
 };
 
+interface PresentationConnection {

[mark a. foltz, 2016/10/21 00:53:03]

Can you add a TODO to migrate SendSessionMessage from PresenationService =>
PresentationConnection.Send()?

[zhaobin, 2016/10/22 02:44:14]

Done.

+   // Called to set the PresentationConnection that is the destination for
+   // messages sent and the source of messages received by this connection.
+   SetTargetConnection(PresentationConnection connection);
+
+   // Called when a message is sent by the target connection.
+   OnConnectionMessageReceived(SessionMessage message);

[mark a. foltz, 2016/10/21 00:53:03]

Or just OnMessage() (similar to the Presentation API) since it seems clear as a
member of PresentationConnection that it's a connection message.

[zhaobin, 2016/10/22 02:44:14]

Done.

+};
+
 interface PresentationService {
   // Sets the PresentationServiceClient.
   SetClient(PresentationServiceClient client);
@@ -109,6 +119,9 @@ interface PresentationService {
   // PresentationServiceClient::OnSessionMessagesReceived.
   // This is called after a presentation session is created.
   ListenForSessionMessages(PresentationSessionInfo sessionInfo);
+
+  SetPresentationConnection(PresentationSessionInfo sessionInfo,

[mark a. foltz, 2016/10/21 00:53:03]

Document this function.  Is it called on the controller, the receiver or both?

[zhaobin, 2016/10/22 02:44:14]

Done.

+                            PresentationConnection connection);
 };
 
 interface PresentationServiceClient {
@@ -142,6 +155,8 @@ interface PresentationServiceClient {
   // See PresentationService::SetDefaultPresentationURL.
   OnDefaultSessionStarted(PresentationSessionInfo sessionInfo);

[mark a. foltz, 2016/10/21 00:53:03]

Can this be moved above with the other controller-only functions?

Maybe we can eventually combine this with OnReceiverConnectionAvailable and just
have OnConnectionAvailable.  (Not to be done in this change.)

In the controlling page, it signals that the browser has started a presentation.
In the receiving page, it signals that the controller has connected to the
receiver.

Would that make sense, or is it more confusing?  Not sure.

[zhaobin, 2016/10/22 02:44:14]

Done.

 
-  // See PresentationService::ListeningForReceiverPageRendered.
-  OnReceiverConnectionAvailable(PresentationSessionInfo sessionInfo);
+  // Called on a presentation receiver when the first presentation connection is
+  // available from the controlling page.
+  OnReceiverConnectionAvailable(PresentationSessionInfo sessionInfo,

[mark a. foltz, 2016/10/21 00:53:03]

Maybe this should be OnFirstConnectionAvailable?  Or is it called for all
connections to the receiver page?

[zhaobin, 2016/10/22 02:44:14]

It is called for all connections to the receiver page.

+                                PresentationConnection connection);
 };