[Presentation API] (alternative) 1-UA: send message between controller and receiver page

content/renderer/presentation/presentation_connection_client.h

Index: content/renderer/presentation/presentation_connection_client.h
diff --git a/content/renderer/presentation/presentation_connection_client.h b/content/renderer/presentation/presentation_connection_client.h
index f8e0bac00034b04684557338fcb418b5edb9c314..31c6b0ce97f9c205a06af52fe3544fa65ef3b5e0 100644
--- a/content/renderer/presentation/presentation_connection_client.h
+++ b/content/renderer/presentation/presentation_connection_client.h
@@ -20,17 +20,29 @@ class CONTENT_EXPORT PresentationConnectionClient
  public:
   explicit PresentationConnectionClient(
       blink::mojom::PresentationSessionInfoPtr session_info);
-  explicit PresentationConnectionClient(const GURL& url,
-                                        const mojo::String& id);
+  PresentationConnectionClient(const GURL& url, const mojo::String& id);
+  // Call this constructor to create PresentationConnectionClient for
+  // 1-UA presentation.
+  // |session_info|: contains presentation id and url info

[mark a. foltz, 2016/10/21 00:53:02]

nit: "Contains presentation ID and URL info."

[zhaobin, 2016/10/22 02:44:13]

Done.

+  // |proxy|: proxy to blink PresentationConnection object in current render

[mark a. foltz, 2016/10/21 00:53:02]

nit: Proxy

[zhaobin, 2016/10/22 02:44:13]

Done.

+  //          process. Ownership is passed to this class.
+  PresentationConnectionClient(
+      blink::mojom::PresentationSessionInfoPtr session_info,
+      std::unique_ptr<blink::WebPresentationConnectionProxy> proxy);
   ~PresentationConnectionClient() override;
 
   // WebPresentationConnectionClient implementation.
   blink::WebURL getUrl() override;
   blink::WebString getId() override;
+  // Returns proxy passed into this class.
+  // It will transfer ownership of |proxy_| to calling object
+  // (PresentationConnection).

[mark a. foltz, 2016/10/21 00:53:02]

Rewrap comments at 80 columns.

[zhaobin, 2016/10/22 02:44:13]

Done.

+  std::unique_ptr<blink::WebPresentationConnectionProxy> getProxy() override;

[mark a. foltz, 2016/10/21 00:53:02]

Can this be takeProxy() to denote change of ownership?

[zhaobin, 2016/10/22 02:44:13]

Done.

 
  private:
   blink::WebURL url_;
   blink::WebString id_;
+  std::unique_ptr<blink::WebPresentationConnectionProxy> proxy_;
 };
 
 }  // namespace content