Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: content/public/browser/presentation_session.cc

Issue 2379703002: [Presentation API] (alternative) 1-UA: send message between controller and receiver page (Closed)
Patch Set: resolve code review comments from Mark Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/browser/presentation_session.h" 5 #include "content/public/browser/presentation_session.h"
6 6
7 namespace content { 7 namespace content {
8 8
9 PresentationSessionInfo::PresentationSessionInfo( 9 PresentationSessionInfo::PresentationSessionInfo(
10 const GURL& presentation_url, 10 const GURL& presentation_url,
11 const std::string& presentation_id) 11 const std::string& presentation_id)
12 : presentation_url(presentation_url), presentation_id(presentation_id) {} 12 : presentation_url(presentation_url),
imcheng 2016/11/01 17:20:29 nit: Use the delegated constructor pattern: Presen
zhaobin 2016/11/02 03:55:47 Done.
13 presentation_id(presentation_id),
14 is_offscreen(false) {}
15
16 PresentationSessionInfo::PresentationSessionInfo(
17 const GURL& presentation_url,
18 const std::string& presentation_id,
19 bool is_offscreen)
20 : presentation_url(presentation_url),
21 presentation_id(presentation_id),
22 is_offscreen(is_offscreen) {}
13 23
14 PresentationSessionInfo::~PresentationSessionInfo() { 24 PresentationSessionInfo::~PresentationSessionInfo() {
15 } 25 }
16 26
17 PresentationError::PresentationError( 27 PresentationError::PresentationError(
18 PresentationErrorType error_type, 28 PresentationErrorType error_type,
19 const std::string& message) 29 const std::string& message)
20 : error_type(error_type), 30 : error_type(error_type),
21 message(message) { 31 message(message) {
22 } 32 }
23 33
24 PresentationError::~PresentationError() { 34 PresentationError::~PresentationError() {
25 } 35 }
26 36
27 } // namespace content 37 } // namespace content
28 38
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698