[Presentation API] (alternative) 1-UA: send message between controller and receiver page

third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/presentation/PresentationConnection.h"
 
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "core/dom/DOMArrayBuffer.h"
 #include "core/dom/DOMArrayBufferView.h"
 #include "core/dom/Document.h"
@@ skipping 124 matching lines @@
 
   void cancel() { m_loader->cancel(); }
 
   DEFINE_INLINE_TRACE() { visitor->trace(m_PresentationConnection); }
 
  private:
   Member<PresentationConnection> m_PresentationConnection;
   std::unique_ptr<FileReaderLoader> m_loader;
 };
 
-PresentationConnection::PresentationConnection(LocalFrame* frame,
-                                               const String& id,
-                                               const KURL& url)
+PresentationConnection::PresentationConnection(
+    LocalFrame* frame,
+    const String& id,
+    const KURL& url,
+    std::unique_ptr<WebPresentationConnectionProxy> proxy)
     : DOMWindowProperty(frame),
       m_id(id),
       m_url(url),
       m_state(WebPresentationConnectionState::Connected),
-      m_binaryType(BinaryTypeBlob) {}
+      m_binaryType(BinaryTypeBlob) {
+  // proxy != nullptr if presentation connection is

[mark a. foltz, 2016/10/21 00:53:03]

Can you wrap this comment at 80 columns?

[zhaobin, 2016/10/22 02:44:13]

Done.

+  // offscreen presentation connection (1-UA);
+  // proxy == nullptr in other cases.
+  if (!proxy)

[mark a. foltz, 2016/10/21 00:53:03]

Since the proxy is optional, I have a slight preference to setting it outside
the constructor, i.e. have a SetPresentationConnectionProxy(proxy) method.

[zhaobin, 2016/10/22 02:44:13]

Done.

+    return;
+
+  m_proxy = std::move(proxy);
+  m_proxy->SetSourceConnection(this);
+}
 
 PresentationConnection::~PresentationConnection() {
   ASSERT(!m_blobLoader);
 }
 
 // static
 PresentationConnection* PresentationConnection::take(
     ScriptPromiseResolver* resolver,
     std::unique_ptr<WebPresentationConnectionClient> client,
     PresentationRequest* request) {
@@ skipping 15 matching lines @@
 }
 
 // static
 PresentationConnection* PresentationConnection::take(
     PresentationController* controller,
     std::unique_ptr<WebPresentationConnectionClient> client,
     PresentationRequest* request) {
   ASSERT(controller);
   ASSERT(request);
 
-  PresentationConnection* connection = new PresentationConnection(
-      controller->frame(), client->getId(), client->getUrl());
+  PresentationConnection* connection =
+      new PresentationConnection(controller->frame(), client->getId(),
+                                 client->getUrl(), client->getProxy());
   controller->registerConnection(connection);
   request->dispatchEvent(PresentationConnectionAvailableEvent::create(
       EventTypeNames::connectionavailable, connection));
 
   return connection;
 }
 
 // static
 PresentationConnection* PresentationConnection::take(
     PresentationReceiver* receiver,
     std::unique_ptr<WebPresentationConnectionClient> client) {
   DCHECK(receiver);
   DCHECK(client);
 
   PresentationConnection* connection = new PresentationConnection(
-      receiver->frame(), client->getId(), client->getUrl());
+      receiver->frame(), client->getId(), client->getUrl(), client->getProxy());
   receiver->registerConnection(connection);
 
   return connection;
 }
 
 const AtomicString& PresentationConnection::interfaceName() const {
   return EventTargetNames::PresentationConnection;
 }
 
 ExecutionContext* PresentationConnection::getExecutionContext() const {
@@ skipping 81 matching lines @@
 
 void PresentationConnection::handleMessageQueue() {
   WebPresentationClient* client = presentationClient(getExecutionContext());
   if (!client)
     return;
 
   while (!m_messages.isEmpty() && !m_blobLoader) {
     Message* message = m_messages.first().get();
     switch (message->type) {
       case MessageTypeText:
+        if (m_proxy)
+          m_proxy->SendString(message->text);

[mark a. foltz, 2016/10/21 00:53:03]

Do we want to send the string to both |m_proxy| and |client|?

[zhaobin, 2016/10/22 02:44:14]

Done.

         client->sendString(m_url, m_id, message->text);
         m_messages.removeFirst();
         break;
       case MessageTypeArrayBuffer:
+        if (m_proxy) {
+          m_proxy->SendArrayBuffer(

[mark a. foltz, 2016/10/21 00:53:03]

Same comment applies here.

[zhaobin, 2016/10/22 02:44:14]

Done.

+              static_cast<const uint8_t*>(message->arrayBuffer->data()),
+              message->arrayBuffer->byteLength());
+        }
         client->sendArrayBuffer(m_url, m_id, static_cast<const uint8_t*>(
                                                  message->arrayBuffer->data()),
                                 message->arrayBuffer->byteLength());
         m_messages.removeFirst();
         break;
       case MessageTypeBlob:
         ASSERT(!m_blobLoader);
         m_blobLoader = new BlobLoader(message->blobDataHandle, this);
         break;
     }
@@ skipping 16 matching lines @@
     m_binaryType = BinaryTypeBlob;
     return;
   }
   if (binaryType == "arraybuffer") {
     m_binaryType = BinaryTypeArrayBuffer;
     return;
   }
   ASSERT_NOT_REACHED();
 }
 
-void PresentationConnection::didReceiveTextMessage(const String& message) {
+void PresentationConnection::didReceiveTextMessage(const WebString& message) {
   if (m_state != WebPresentationConnectionState::Connected)
     return;
 
   dispatchEvent(MessageEvent::create(message));
 }
 
 void PresentationConnection::didReceiveBinaryMessage(const uint8_t* data,
                                                      size_t length) {
   if (m_state != WebPresentationConnectionState::Connected)
     return;
@@ skipping 100 matching lines @@
 void PresentationConnection::tearDown() {
   // Cancel current Blob loading if any.
   if (m_blobLoader) {
     m_blobLoader->cancel();
     m_blobLoader.clear();
   }
   m_messages.clear();
 }
 
 }  // namespace blink