Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2379673002: Add the shortcut to toggle high contrast mode to the keyboard overlay (Closed)

Created:
4 years, 2 months ago by afakhry
Modified:
4 years, 2 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the shortcut to toggle high contrast mode to the keyboard overlay Screenshot https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LMUpQRG02OXRYU1k/view?usp=sharing BUG=644758 TEST=open keyboard overlay, hit Ctrl+Alt, and look at the H key. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/23f688e8fe28d1b260cedba104bf0783331126d4 Cr-Commit-Position: refs/heads/master@{#421587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
afakhry
Xiyuan, please review. Thank you!
4 years, 2 months ago (2016-09-28 17:17:09 UTC) #5
xiyuan
lgtm
4 years, 2 months ago (2016-09-28 17:20:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379673002/20001
4 years, 2 months ago (2016-09-28 17:38:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-09-28 18:36:43 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/23f688e8fe28d1b260cedba104bf0783331126d4 Cr-Commit-Position: refs/heads/master@{#421587}
4 years, 2 months ago (2016-09-28 18:39:36 UTC) #12
dmazzoni
4 years, 1 month ago (2016-10-24 17:56:41 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/2443303002/ by dmazzoni@chromium.org.

The reason for reverting is: http://crbug.com/653330 This shortcut
conflicts with some web pages, and there's
no consensus on the proper fix (let web pages
override, or switch to another key).

.

Powered by Google App Engine
This is Rietveld 408576698