Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2379663002: Reland "[heap] New heuristics for starting of incremental marking. (patchset #9 id:160001 of https:… (Closed)

Created:
4 years, 2 months ago by ulan
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[heap] New heuristics for starting of incremental marking. (patchset #9 id:160001 of https://codereview.chromium.org/2364923002/ )" This reverts commit a5440d11908d3a096aa570d62a01a9a018b8af48. BUG=chromium:616434 TBR=hpayer@chromium.org LOG=NO Committed: https://crrev.com/7e652694a0bd29da4891ac7d7acf2f0e25930cd1 Cr-Commit-Position: refs/heads/master@{#39838}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -81 lines) Patch
M src/heap/heap.h View 5 chunks +19 lines, -15 lines 0 comments Download
M src/heap/heap.cc View 5 chunks +57 lines, -13 lines 0 comments Download
M src/heap/heap-inl.h View 2 chunks +0 lines, -19 lines 0 comments Download
M src/heap/incremental-marking.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/heap/incremental-marking-job.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +1 line, -13 lines 0 comments Download
M test/cctest/heap/heap-tester.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
ulan
Relanding, the fix is in PS2
4 years, 2 months ago (2016-09-28 17:20:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379663002/60001
4 years, 2 months ago (2016-09-28 17:21:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 2 months ago (2016-09-28 17:51:52 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 17:52:07 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e652694a0bd29da4891ac7d7acf2f0e25930cd1
Cr-Commit-Position: refs/heads/master@{#39838}

Powered by Google App Engine
This is Rietveld 408576698