Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: cc/surfaces/surface_manager.h

Issue 2379653006: Replaced cc::SurfaceId::nonce_ with base::UnguessableToken (Closed)
Patch Set: Changed SurfaceManager::kRootSurfaceId to a private field to avoid static initialization Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_id_allocator.cc ('k') | cc/surfaces/surface_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_manager.h
diff --git a/cc/surfaces/surface_manager.h b/cc/surfaces/surface_manager.h
index bbd6e144f6860c54e0a9f15c6e1f1a346cc61938..b52fce25adef17a8d5ac2fbe2611a20b61bc00d2 100644
--- a/cc/surfaces/surface_manager.h
+++ b/cc/surfaces/surface_manager.h
@@ -30,10 +30,6 @@ class SurfaceFactoryClient;
class CC_SURFACES_EXPORT SurfaceManager {
public:
- // Root SurfaceId that references display root surfaces. There is no Surface
- // with this id, it's for bookkeeping purposes only.
- static const SurfaceId kRootSurfaceId;
-
SurfaceManager();
~SurfaceManager();
@@ -122,6 +118,8 @@ class CC_SURFACES_EXPORT SurfaceManager {
void UnregisterFrameSinkHierarchy(const FrameSinkId& parent_frame_sink_id,
const FrameSinkId& child_frame_sink_id);
+ const SurfaceId& GetRootSurfaceId() { return kRootSurfaceId; }
+
private:
void RecursivelyAttachBeginFrameSource(const FrameSinkId& frame_sink_id,
BeginFrameSource* source);
@@ -191,6 +189,10 @@ class CC_SURFACES_EXPORT SurfaceManager {
// parent in the dag.
std::unordered_map<BeginFrameSource*, FrameSinkId> registered_sources_;
+ // Root SurfaceId that references display root surfaces. There is no Surface
+ // with this id, it's for bookkeeping purposes only.
+ const SurfaceId kRootSurfaceId;
+
DISALLOW_COPY_AND_ASSIGN(SurfaceManager);
};
« no previous file with comments | « cc/surfaces/surface_id_allocator.cc ('k') | cc/surfaces/surface_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698