Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1634)

Unified Diff: content/browser/renderer_host/delegated_frame_host.cc

Issue 2379653006: Replaced cc::SurfaceId::nonce_ with base::UnguessableToken (Closed)
Patch Set: Added static cast to LocalFrameId::hash() to avoid warnings when compiled on Windows Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/delegated_frame_host.cc
diff --git a/content/browser/renderer_host/delegated_frame_host.cc b/content/browser/renderer_host/delegated_frame_host.cc
index 2457eaef2925f40e7241def67cbd9667dd6f98ad..b150fe7c58c8f1972ffbc06ba3af4b43eff6ad96 100644
--- a/content/browser/renderer_host/delegated_frame_host.cc
+++ b/content/browser/renderer_host/delegated_frame_host.cc
@@ -216,7 +216,10 @@ cc::SurfaceId DelegatedFrameHost::SurfaceIdAtPoint(
const gfx::Point& point,
gfx::Point* transformed_point) {
cc::SurfaceId surface_id(frame_sink_id_, local_frame_id_);
- if (surface_id.is_null())
+ // TODO(staraz): Kludge: The is_null() check is causing tests to fail.
+ // The proper fix is to change it to is_valid which is going to be added in
+ // another CL
+ if (frame_sink_id_.is_null() || local_frame_id_.is_null())
return surface_id;
cc::SurfaceHittest hittest(delegate, GetSurfaceManager());
gfx::Transform target_transform;

Powered by Google App Engine
This is Rietveld 408576698