Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: cc/surfaces/local_frame_id.h

Issue 2379653006: Replaced cc::SurfaceId::nonce_ with base::UnguessableToken (Closed)
Patch Set: Changed SurfaceManager::kRootSurfaceId to a private field to avoid static initialization Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/surfaces/display_scheduler_unittest.cc ('k') | cc/surfaces/surface_aggregator_perftest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_SURFACES_LOCAL_FRAME_ID_H_ 5 #ifndef CC_SURFACES_LOCAL_FRAME_ID_H_
6 #define CC_SURFACES_LOCAL_FRAME_ID_H_ 6 #define CC_SURFACES_LOCAL_FRAME_ID_H_
7 7
8 #include <inttypes.h> 8 #include <inttypes.h>
9 #include <tuple> 9 #include <tuple>
10 10
11 #include "base/hash.h" 11 #include "base/hash.h"
12 #include "base/strings/stringprintf.h" 12 #include "base/strings/stringprintf.h"
13 #include "base/unguessable_token.h"
13 14
14 namespace cc { 15 namespace cc {
15 16
16 class LocalFrameId { 17 class LocalFrameId {
17 public: 18 public:
18 constexpr LocalFrameId() : local_id_(0), nonce_(0) {} 19 constexpr LocalFrameId() : local_id_(0) {}
19 20
20 constexpr LocalFrameId(const LocalFrameId& other) 21 constexpr LocalFrameId(const LocalFrameId& other)
21 : local_id_(other.local_id_), nonce_(other.nonce_) {} 22 : local_id_(other.local_id_), nonce_(other.nonce_) {}
22 23
23 constexpr LocalFrameId(uint32_t local_id, uint64_t nonce) 24 constexpr LocalFrameId(uint32_t local_id, const base::UnguessableToken& nonce)
24 : local_id_(local_id), nonce_(nonce) {} 25 : local_id_(local_id), nonce_(nonce) {}
25 26
26 constexpr bool is_valid() const { return local_id_ != 0 && nonce_ != 0; } 27 constexpr bool is_valid() const {
28 return local_id_ != 0 && !nonce_.is_empty();
29 }
27 30
28 constexpr uint32_t local_id() const { return local_id_; } 31 constexpr uint32_t local_id() const { return local_id_; }
29 32
30 constexpr uint64_t nonce() const { return nonce_; } 33 constexpr const base::UnguessableToken& nonce() const { return nonce_; }
31 34
32 bool operator==(const LocalFrameId& other) const { 35 bool operator==(const LocalFrameId& other) const {
33 return local_id_ == other.local_id_ && nonce_ == other.nonce_; 36 return local_id_ == other.local_id_ && nonce_ == other.nonce_;
34 } 37 }
35 38
36 bool operator!=(const LocalFrameId& other) const { return !(*this == other); } 39 bool operator!=(const LocalFrameId& other) const { return !(*this == other); }
37 40
38 bool operator<(const LocalFrameId& other) const { 41 bool operator<(const LocalFrameId& other) const {
39 return std::tie(local_id_, nonce_) < 42 return std::tie(local_id_, nonce_) <
40 std::tie(other.local_id_, other.nonce_); 43 std::tie(other.local_id_, other.nonce_);
41 } 44 }
42 45
43 size_t hash() const { return base::HashInts(local_id_, nonce_); } 46 size_t hash() const {
47 return base::HashInts(
48 local_id_, static_cast<uint64_t>(base::UnguessableTokenHash()(nonce_)));
49 }
44 50
45 std::string ToString() const { 51 std::string ToString() const {
46 return base::StringPrintf("LocalFrameId(%d, %" PRIu64 ")", local_id_, 52 return base::StringPrintf("LocalFrameId(%d, %s" PRIu64 ")", local_id_,
47 nonce_); 53 nonce_.ToString().c_str());
48 } 54 }
49 55
50 private: 56 private:
51 uint32_t local_id_; 57 uint32_t local_id_;
52 uint64_t nonce_; 58 base::UnguessableToken nonce_;
53 }; 59 };
54 60
55 struct LocalFrameIdHash { 61 struct LocalFrameIdHash {
56 size_t operator()(const LocalFrameId& key) const { return key.hash(); } 62 size_t operator()(const LocalFrameId& key) const { return key.hash(); }
57 }; 63 };
58 64
59 } // namespace cc 65 } // namespace cc
60 66
61 #endif // CC_SURFACES_LOCAL_FRAME_ID_H_ 67 #endif // CC_SURFACES_LOCAL_FRAME_ID_H_
OLDNEW
« no previous file with comments | « cc/surfaces/display_scheduler_unittest.cc ('k') | cc/surfaces/surface_aggregator_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698