Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: cc/layers/surface_layer_impl_unittest.cc

Issue 2379653006: Replaced cc::SurfaceId::nonce_ with base::UnguessableToken (Closed)
Patch Set: Nit change based on comment. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/layers/surface_layer_impl.h" 5 #include "cc/layers/surface_layer_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "cc/test/layer_test_common.h" 9 #include "cc/test/layer_test_common.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 namespace cc { 12 namespace cc {
13 namespace { 13 namespace {
14 14
15 static constexpr FrameSinkId kArbitraryFrameSinkId(1, 1); 15 static constexpr FrameSinkId kArbitraryFrameSinkId(1, 1);
16 static const LocalFrameId kArbitraryLocalFrameId(
17 9,
18 base::UnguessableToken::Create());
dcheng 2016/11/09 22:10:48 I'm surprised that clang doesn't complain here.
Alex Z. 2016/11/10 15:57:43 Done.
16 19
17 TEST(SurfaceLayerImplTest, Occlusion) { 20 TEST(SurfaceLayerImplTest, Occlusion) {
18 gfx::Size layer_size(1000, 1000); 21 gfx::Size layer_size(1000, 1000);
19 gfx::Size viewport_size(1000, 1000); 22 gfx::Size viewport_size(1000, 1000);
20 23
21 LayerTestCommon::LayerImplTest impl; 24 LayerTestCommon::LayerImplTest impl;
22 25
23 SurfaceLayerImpl* surface_layer_impl = 26 SurfaceLayerImpl* surface_layer_impl =
24 impl.AddChildToRoot<SurfaceLayerImpl>(); 27 impl.AddChildToRoot<SurfaceLayerImpl>();
25 surface_layer_impl->SetBounds(layer_size); 28 surface_layer_impl->SetBounds(layer_size);
26 surface_layer_impl->SetDrawsContent(true); 29 surface_layer_impl->SetDrawsContent(true);
27 SurfaceId surface_id(kArbitraryFrameSinkId, LocalFrameId(9, 1)); 30 SurfaceId surface_id(kArbitraryFrameSinkId, kArbitraryLocalFrameId);
28 surface_layer_impl->SetSurfaceId(surface_id); 31 surface_layer_impl->SetSurfaceId(surface_id);
29 surface_layer_impl->SetSurfaceScale(1.f); 32 surface_layer_impl->SetSurfaceScale(1.f);
30 surface_layer_impl->SetSurfaceSize(layer_size); 33 surface_layer_impl->SetSurfaceSize(layer_size);
31 34
32 impl.CalcDrawProps(viewport_size); 35 impl.CalcDrawProps(viewport_size);
33 36
34 { 37 {
35 SCOPED_TRACE("No occlusion"); 38 SCOPED_TRACE("No occlusion");
36 gfx::Rect occluded; 39 gfx::Rect occluded;
37 impl.AppendQuadsWithOcclusion(surface_layer_impl, occluded); 40 impl.AppendQuadsWithOcclusion(surface_layer_impl, occluded);
(...skipping 21 matching lines...) Expand all
59 LayerTestCommon::VerifyQuadsAreOccluded( 62 LayerTestCommon::VerifyQuadsAreOccluded(
60 impl.quad_list(), occluded, &partially_occluded_count); 63 impl.quad_list(), occluded, &partially_occluded_count);
61 // The layer outputs one quad, which is partially occluded. 64 // The layer outputs one quad, which is partially occluded.
62 EXPECT_EQ(1u, impl.quad_list().size()); 65 EXPECT_EQ(1u, impl.quad_list().size());
63 EXPECT_EQ(1u, partially_occluded_count); 66 EXPECT_EQ(1u, partially_occluded_count);
64 } 67 }
65 } 68 }
66 69
67 } // namespace 70 } // namespace
68 } // namespace cc 71 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698