Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: cc/ipc/struct_traits_unittest.cc

Issue 2379653006: Replaced cc::SurfaceId::nonce_ with base::UnguessableToken (Closed)
Patch Set: Changed comments in surface_id.h to reflect the change Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/message_loop/message_loop.h" 5 #include "base/message_loop/message_loop.h"
6 #include "cc/input/selection.h" 6 #include "cc/input/selection.h"
7 #include "cc/ipc/traits_test_service.mojom.h" 7 #include "cc/ipc/traits_test_service.mojom.h"
8 #include "cc/quads/debug_border_draw_quad.h" 8 #include "cc/quads/debug_border_draw_quad.h"
9 #include "cc/quads/render_pass.h" 9 #include "cc/quads/render_pass.h"
10 #include "cc/quads/render_pass_draw_quad.h" 10 #include "cc/quads/render_pass_draw_quad.h"
(...skipping 268 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 selection.end.set_visible(false); 279 selection.end.set_visible(false);
280 selection.end.set_type(gfx::SelectionBound::RIGHT); 280 selection.end.set_type(gfx::SelectionBound::RIGHT);
281 selection.is_editable = true; 281 selection.is_editable = true;
282 selection.is_empty_text_form_control = true; 282 selection.is_empty_text_form_control = true;
283 ui::LatencyInfo latency_info; 283 ui::LatencyInfo latency_info;
284 latency_info.AddLatencyNumber( 284 latency_info.AddLatencyNumber(
285 ui::LATENCY_BEGIN_SCROLL_LISTENER_UPDATE_MAIN_COMPONENT, 1337, 7331); 285 ui::LATENCY_BEGIN_SCROLL_LISTENER_UPDATE_MAIN_COMPONENT, 1337, 7331);
286 std::vector<ui::LatencyInfo> latency_infos = {latency_info}; 286 std::vector<ui::LatencyInfo> latency_infos = {latency_info};
287 std::vector<uint32_t> satisfies_sequences = {1234, 1337}; 287 std::vector<uint32_t> satisfies_sequences = {1234, 1337};
288 std::vector<SurfaceId> referenced_surfaces; 288 std::vector<SurfaceId> referenced_surfaces;
289 SurfaceId id(FrameSinkId(1234, 4321), LocalFrameId(5678, 9101112)); 289 SurfaceId id(FrameSinkId(1234, 4321),
290 LocalFrameId(5678, base::UnguessableToken::Create()));
290 referenced_surfaces.push_back(id); 291 referenced_surfaces.push_back(id);
291 292
292 CompositorFrameMetadata input; 293 CompositorFrameMetadata input;
293 input.device_scale_factor = device_scale_factor; 294 input.device_scale_factor = device_scale_factor;
294 input.root_scroll_offset = root_scroll_offset; 295 input.root_scroll_offset = root_scroll_offset;
295 input.page_scale_factor = page_scale_factor; 296 input.page_scale_factor = page_scale_factor;
296 input.scrollable_viewport_size = scrollable_viewport_size; 297 input.scrollable_viewport_size = scrollable_viewport_size;
297 input.root_layer_size = root_layer_size; 298 input.root_layer_size = root_layer_size;
298 input.min_page_scale_factor = min_page_scale_factor; 299 input.min_page_scale_factor = min_page_scale_factor;
299 input.max_page_scale_factor = max_page_scale_factor; 300 input.max_page_scale_factor = max_page_scale_factor;
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
431 debug_quad->SetNew(sqs, rect1, rect1, color1, width1); 432 debug_quad->SetNew(sqs, rect1, rect1, color1, width1);
432 433
433 const gfx::Rect rect2(2468, 8642, 4321, 1234); 434 const gfx::Rect rect2(2468, 8642, 4321, 1234);
434 const uint32_t color2 = 0xffffffff; 435 const uint32_t color2 = 0xffffffff;
435 const bool force_anti_aliasing_off = true; 436 const bool force_anti_aliasing_off = true;
436 SolidColorDrawQuad* solid_quad = 437 SolidColorDrawQuad* solid_quad =
437 render_pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>(); 438 render_pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>();
438 solid_quad->SetNew(sqs, rect2, rect2, color2, force_anti_aliasing_off); 439 solid_quad->SetNew(sqs, rect2, rect2, color2, force_anti_aliasing_off);
439 440
440 const gfx::Rect rect3(1029, 3847, 5610, 2938); 441 const gfx::Rect rect3(1029, 3847, 5610, 2938);
441 const SurfaceId surface_id(FrameSinkId(1234, 4321), LocalFrameId(5678, 2468)); 442 const SurfaceId surface_id(
443 FrameSinkId(1234, 4321),
444 LocalFrameId(5678, base::UnguessableToken::Create()));
442 SurfaceDrawQuad* surface_quad = 445 SurfaceDrawQuad* surface_quad =
443 render_pass->CreateAndAppendDrawQuad<SurfaceDrawQuad>(); 446 render_pass->CreateAndAppendDrawQuad<SurfaceDrawQuad>();
444 surface_quad->SetNew(sqs, rect3, rect3, surface_id); 447 surface_quad->SetNew(sqs, rect3, rect3, surface_id);
445 448
446 const gfx::Rect rect4(1234, 5678, 9101112, 13141516); 449 const gfx::Rect rect4(1234, 5678, 9101112, 13141516);
447 const ResourceId resource_id4(1337); 450 const ResourceId resource_id4(1337);
448 const RenderPassId render_pass_id(1234, 5678); 451 const RenderPassId render_pass_id(1234, 5678);
449 const gfx::Vector2dF mask_uv_scale(1337.1f, 1234.2f); 452 const gfx::Vector2dF mask_uv_scale(1337.1f, 1234.2f);
450 const gfx::Size mask_texture_size(1234, 5678); 453 const gfx::Size mask_texture_size(1234, 5678);
451 FilterOperations filters; 454 FilterOperations filters;
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
604 input->CreateAndAppendDrawQuad<SolidColorDrawQuad>(); 607 input->CreateAndAppendDrawQuad<SolidColorDrawQuad>();
605 const gfx::Rect color_quad_rect(123, 456, 789, 101); 608 const gfx::Rect color_quad_rect(123, 456, 789, 101);
606 color_quad->SetNew(shared_state_2, color_quad_rect, color_quad_rect, 609 color_quad->SetNew(shared_state_2, color_quad_rect, color_quad_rect,
607 SK_ColorRED, true); 610 SK_ColorRED, true);
608 611
609 SurfaceDrawQuad* surface_quad = 612 SurfaceDrawQuad* surface_quad =
610 input->CreateAndAppendDrawQuad<SurfaceDrawQuad>(); 613 input->CreateAndAppendDrawQuad<SurfaceDrawQuad>();
611 const gfx::Rect surface_quad_rect(1337, 2448, 1234, 5678); 614 const gfx::Rect surface_quad_rect(1337, 2448, 1234, 5678);
612 surface_quad->SetNew( 615 surface_quad->SetNew(
613 shared_state_2, surface_quad_rect, surface_quad_rect, 616 shared_state_2, surface_quad_rect, surface_quad_rect,
614 SurfaceId(FrameSinkId(1337, 1234), LocalFrameId(1234, 2468))); 617 SurfaceId(FrameSinkId(1337, 1234),
618 LocalFrameId(1234, base::UnguessableToken::Create())));
615 619
616 std::unique_ptr<RenderPass> output; 620 std::unique_ptr<RenderPass> output;
617 mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy(); 621 mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy();
618 proxy->EchoRenderPass(input->DeepCopy(), &output); 622 proxy->EchoRenderPass(input->DeepCopy(), &output);
619 623
620 EXPECT_EQ(input->quad_list.size(), output->quad_list.size()); 624 EXPECT_EQ(input->quad_list.size(), output->quad_list.size());
621 EXPECT_EQ(input->shared_quad_state_list.size(), 625 EXPECT_EQ(input->shared_quad_state_list.size(),
622 output->shared_quad_state_list.size()); 626 output->shared_quad_state_list.size());
623 EXPECT_EQ(id, output->id); 627 EXPECT_EQ(id, output->id);
624 EXPECT_EQ(output_rect, output->output_rect); 628 EXPECT_EQ(output_rect, output->output_rect);
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
759 Selection<gfx::SelectionBound> output; 763 Selection<gfx::SelectionBound> output;
760 proxy->EchoSelection(input, &output); 764 proxy->EchoSelection(input, &output);
761 EXPECT_EQ(start, output.start); 765 EXPECT_EQ(start, output.start);
762 EXPECT_EQ(end, output.end); 766 EXPECT_EQ(end, output.end);
763 EXPECT_EQ(is_editable, output.is_editable); 767 EXPECT_EQ(is_editable, output.is_editable);
764 EXPECT_EQ(is_empty_text_form_control, output.is_empty_text_form_control); 768 EXPECT_EQ(is_empty_text_form_control, output.is_empty_text_form_control);
765 } 769 }
766 770
767 TEST_F(StructTraitsTest, SurfaceId) { 771 TEST_F(StructTraitsTest, SurfaceId) {
768 static constexpr FrameSinkId frame_sink_id(1337, 1234); 772 static constexpr FrameSinkId frame_sink_id(1337, 1234);
769 static constexpr LocalFrameId local_frame_id(0xfbadbeef, 0xdeadbeef); 773 static LocalFrameId local_frame_id(0xfbadbeef,
774 base::UnguessableToken::Create());
770 SurfaceId input(frame_sink_id, local_frame_id); 775 SurfaceId input(frame_sink_id, local_frame_id);
771 mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy(); 776 mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy();
772 SurfaceId output; 777 SurfaceId output;
773 proxy->EchoSurfaceId(input, &output); 778 proxy->EchoSurfaceId(input, &output);
774 EXPECT_EQ(frame_sink_id, output.frame_sink_id()); 779 EXPECT_EQ(frame_sink_id, output.frame_sink_id());
775 EXPECT_EQ(local_frame_id, output.local_frame_id()); 780 EXPECT_EQ(local_frame_id, output.local_frame_id());
776 } 781 }
777 782
778 TEST_F(StructTraitsTest, SurfaceSequence) { 783 TEST_F(StructTraitsTest, SurfaceSequence) {
779 const FrameSinkId frame_sink_id(2016, 1234); 784 const FrameSinkId frame_sink_id(2016, 1234);
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
918 EXPECT_EQ(u_plane_resource_id, out_quad->u_plane_resource_id()); 923 EXPECT_EQ(u_plane_resource_id, out_quad->u_plane_resource_id());
919 EXPECT_EQ(v_plane_resource_id, out_quad->v_plane_resource_id()); 924 EXPECT_EQ(v_plane_resource_id, out_quad->v_plane_resource_id());
920 EXPECT_EQ(a_plane_resource_id, out_quad->a_plane_resource_id()); 925 EXPECT_EQ(a_plane_resource_id, out_quad->a_plane_resource_id());
921 EXPECT_EQ(color_space, out_quad->color_space); 926 EXPECT_EQ(color_space, out_quad->color_space);
922 EXPECT_EQ(resource_offset, out_quad->resource_offset); 927 EXPECT_EQ(resource_offset, out_quad->resource_offset);
923 EXPECT_EQ(resource_multiplier, out_quad->resource_multiplier); 928 EXPECT_EQ(resource_multiplier, out_quad->resource_multiplier);
924 EXPECT_EQ(bits_per_channel, out_quad->bits_per_channel); 929 EXPECT_EQ(bits_per_channel, out_quad->bits_per_channel);
925 } 930 }
926 931
927 } // namespace cc 932 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698