Rename MediaSourceState -> SourceBufferState

Rename MediaSourceState -> SourceBufferState

The MediaSourceState class is currently somewhat misnamed, there is
actually a 1:1 mapping between blink SourceBuffer objects and current
MediaSourceState objects. But a single blink MediaSource can have
multiple SourceBuffers and thus multiple MediaSourceState objects
associated with it. So a better, clearer name for MediaSourceState is
actually SourceBufferState.

Committed: https://crrev.com/0454c5d6d6edbd2254a2cdfd869ada1799e97695
Cr-Commit-Position: refs/heads/master@{#422234}

[servolk, 2016-09-29 18:15:20]

The CQ bit was checked by servolk@chromium.org to run a CQ dry run

[servolk, 2016-09-29 18:15:33]

Description was changed from

==========
Rename MediaSourceState -> SourceBufferState

Now that a single MediaSource can have multiple SourceBuffers, we
should remove MediaSourceState into SourceBufferState to make avoid
confusion. There is a 1:1 mapping between blink SourceBuffer objects
and SourceBufferState objects.
==========

to

==========
Rename MediaSourceState -> SourceBufferState

Now that a single MediaSource can have multiple SourceBuffers, we
should remove MediaSourceState into SourceBufferState to make avoid
confusion. There is a 1:1 mapping between blink SourceBuffer objects
and SourceBufferState objects.
==========

[servolk, 2016-09-29 18:15:33]

servolk@chromium.org changed reviewers:
+ chcunningham@chromium.org, wolenetz@chromium.org

[commit-bot: I haz the power, 2016-09-29 18:15:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[servolk, 2016-09-29 18:15:58]

Description was changed from

==========
Rename MediaSourceState -> SourceBufferState

Now that a single MediaSource can have multiple SourceBuffers, we
should remove MediaSourceState into SourceBufferState to make avoid
confusion. There is a 1:1 mapping between blink SourceBuffer objects
and SourceBufferState objects.
==========

to

==========
Rename MediaSourceState -> SourceBufferState

Now that a single MediaSource can have multiple SourceBuffers, we
should remove MediaSourceState into SourceBufferState to avoid
confusion. There is a 1:1 mapping between blink SourceBuffer objects
and SourceBufferState objects.
==========

[chcunningham, 2016-09-29 19:35:27]

lgtm

[commit-bot: I haz the power, 2016-09-29 19:51:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 19:51:18]

Dry run: This issue passed the CQ dry run.

[servolk, 2016-09-30 01:50:19]

Description was changed from

==========
Rename MediaSourceState -> SourceBufferState

Now that a single MediaSource can have multiple SourceBuffers, we
should remove MediaSourceState into SourceBufferState to avoid
confusion. There is a 1:1 mapping between blink SourceBuffer objects
and SourceBufferState objects.
==========

to

==========
Rename MediaSourceState -> SourceBufferState

Now that a single MediaSource can have multiple SourceBuffers, we
should rename MediaSourceState into SourceBufferState to avoid
confusion. There is a 1:1 mapping between blink SourceBuffer objects
and SourceBufferState objects.
==========

[wolenetz, 2016-09-30 19:22:56]

lgtm % nits:

Description is a little misleading - A MediaSource (even prior to
multitrack-for-same-track-type work) could have multiple SourceBuffers.
MediaSourceState was misnamed for a long time :)

And:

https://codereview.chromium.org/2379653004/diff/1/media/filters/source_buffer...
File media/filters/source_buffer_state_unittest.cc (right):

https://codereview.chromium.org/2379653004/diff/1/media/filters/source_buffer...
media/filters/source_buffer_state_unittest.cc:142:
std::unique_ptr<SourceBufferState> mss =
nit: s/mss/sbs/ here and elsewhere

[servolk, 2016-09-30 20:13:54]

The CQ bit was checked by servolk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 20:14:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[servolk, 2016-09-30 20:14:50]

Description was changed from

==========
Rename MediaSourceState -> SourceBufferState

Now that a single MediaSource can have multiple SourceBuffers, we
should rename MediaSourceState into SourceBufferState to avoid
confusion. There is a 1:1 mapping between blink SourceBuffer objects
and SourceBufferState objects.
==========

to

==========
Rename MediaSourceState -> SourceBufferState

The MediaSourceState class is currently somewhat misnamed, there is
actually a 1:1 mapping between blink SourceBuffer objects and current
MediaSourceState objects. But a single blink MediaSource can have
multiple SourceBuffers and thus multiple MediaSourceState objects
associated with it. So a better, clearer name for MediaSourceState is
actually SourceBufferState.
==========

[servolk, 2016-09-30 20:15:14]

Updated CL description + fixed nits

https://codereview.chromium.org/2379653004/diff/1/media/filters/source_buffer...
File media/filters/source_buffer_state_unittest.cc (right):

https://codereview.chromium.org/2379653004/diff/1/media/filters/source_buffer...
media/filters/source_buffer_state_unittest.cc:142:
std::unique_ptr<SourceBufferState> mss =
On 2016/09/30 19:22:56, wolenetz wrote:
> nit: s/mss/sbs/ here and elsewhere

Done (here and in chunk_demuxer.cc).

[wolenetz, 2016-09-30 20:33:06]

lgtm2 Thanks for doing this, servolk@

[servolk, 2016-09-30 20:34:00]

The CQ bit was unchecked by servolk@chromium.org

[servolk, 2016-09-30 20:34:04]

The CQ bit was checked by servolk@chromium.org

[servolk, 2016-09-30 20:34:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
chcunningham@chromium.org, wolenetz@chromium.org
Link to the patchset: https://codereview.chromium.org/2379653004/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2016-09-30 20:34:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 21:57:31]

Description was changed from

==========
Rename MediaSourceState -> SourceBufferState

The MediaSourceState class is currently somewhat misnamed, there is
actually a 1:1 mapping between blink SourceBuffer objects and current
MediaSourceState objects. But a single blink MediaSource can have
multiple SourceBuffers and thus multiple MediaSourceState objects
associated with it. So a better, clearer name for MediaSourceState is
actually SourceBufferState.
==========

to

==========
Rename MediaSourceState -> SourceBufferState

The MediaSourceState class is currently somewhat misnamed, there is
actually a 1:1 mapping between blink SourceBuffer objects and current
MediaSourceState objects. But a single blink MediaSource can have
multiple SourceBuffers and thus multiple MediaSourceState objects
associated with it. So a better, clearer name for MediaSourceState is
actually SourceBufferState.
==========

[commit-bot: I haz the power, 2016-09-30 21:57:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-30 22:01:13]

Description was changed from

==========
Rename MediaSourceState -> SourceBufferState

The MediaSourceState class is currently somewhat misnamed, there is
actually a 1:1 mapping between blink SourceBuffer objects and current
MediaSourceState objects. But a single blink MediaSource can have
multiple SourceBuffers and thus multiple MediaSourceState objects
associated with it. So a better, clearer name for MediaSourceState is
actually SourceBufferState.
==========

to

==========
Rename MediaSourceState -> SourceBufferState

The MediaSourceState class is currently somewhat misnamed, there is
actually a 1:1 mapping between blink SourceBuffer objects and current
MediaSourceState objects. But a single blink MediaSource can have
multiple SourceBuffers and thus multiple MediaSourceState objects
associated with it. So a better, clearer name for MediaSourceState is
actually SourceBufferState.

Committed: https://crrev.com/0454c5d6d6edbd2254a2cdfd869ada1799e97695
Cr-Commit-Position: refs/heads/master@{#422234}
==========

[commit-bot: I haz the power, 2016-09-30 22:01:14]

Patchset 2 (id:??) landed as
https://crrev.com/0454c5d6d6edbd2254a2cdfd869ada1799e97695
Cr-Commit-Position: refs/heads/master@{#422234}