Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 237963024: Select function map based on prototype and shared function info. (Closed)

Created:
6 years, 8 months ago by Toon Verwaest
Modified:
6 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Select function map based on prototype and shared function info. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20840

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -74 lines) Patch
M src/factory.h View 1 chunk +10 lines, -10 lines 0 comments Download
M src/factory.cc View 1 6 chunks +62 lines, -64 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
6 years, 8 months ago (2014-04-17 10:35:58 UTC) #1
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/237963024/diff/1/src/factory.cc File src/factory.cc (right): https://codereview.chromium.org/237963024/diff/1/src/factory.cc#newcode1742 src/factory.cc:1742: context, the_hole_value()); What about passing ...
6 years, 8 months ago (2014-04-17 11:10:08 UTC) #2
Toon Verwaest
Addressed comment. https://codereview.chromium.org/237963024/diff/1/src/factory.cc File src/factory.cc (right): https://codereview.chromium.org/237963024/diff/1/src/factory.cc#newcode1742 src/factory.cc:1742: context, the_hole_value()); On 2014/04/17 11:10:08, Igor Sheludko ...
6 years, 8 months ago (2014-04-17 11:50:18 UTC) #3
Toon Verwaest
6 years, 8 months ago (2014-04-17 11:50:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20840 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698