Remove remaining window states where window is shown with opacity 0.

Remove remaining window states where window is shown with opacity 0.

BUG=351553
TEST=Unit tests pass, can enter overview mode and show/hide panels in debug mode without triggering DCHECK in window.cc.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265330

[flackr, 2014-04-22 14:15:50]

I took over bug 351553 to fix the panel and overview visibility states (old cl
from skuhne@ here: https://codereview.chromium.org/196723009/). I fixed the
cases where we used to show windows with 0 opacity.

For overview, this was as simple as ensuring that the animation was set up
before showing the window such that target opacity was non zero.

For panels, we used to wait for the shelf to begin animating before we knew
where the shelf icon for the panel was. I reworked this so that
PanelLayoutManager can observe when we assign a shelf icon so that we don't need
the opacity hack to avoid the flash at (0, 0) before the icon position is known.

Please take a look, thanks!

[Mr4D (OOO till 08-26), 2014-04-22 14:45:48]

lgtm with one nit

https://codereview.chromium.org/237963019/diff/70001/ash/wm/panels/panel_layo...
File ash/wm/panels/panel_layout_manager_unittest.cc (right):

https://codereview.chromium.org/237963019/diff/70001/ash/wm/panels/panel_layo...
ash/wm/panels/panel_layout_manager_unittest.cc:581: // Restore the pantel; panel
should not be activated by default but callout
pantel -> panel

https://codereview.chromium.org/237963019/diff/70001/ash/wm/panels/panel_layo...
ash/wm/panels/panel_layout_manager_unittest.cc:751:
wm::GetWindowState(w2.get())->Minimize();
Ah! Thanks for moving this to the new scheme!

https://codereview.chromium.org/237963019/diff/70001/ui/aura/window.cc
File ui/aura/window.cc (right):

https://codereview.chromium.org/237963019/diff/70001/ui/aura/window.cc#newcod...
ui/aura/window.cc:341: // could not be seen.
Yippieh! (let's see what was not covered by unit tests and the real world breaks
now...)

[sky, 2014-04-22 16:06:13]

LGTM

https://codereview.chromium.org/237963019/diff/70001/ash/shelf/shelf_util.h
File ash/shelf/shelf_util.h (right):

https://codereview.chromium.org/237963019/diff/70001/ash/shelf/shelf_util.h#n...
ash/shelf/shelf_util.h:18: extern const aura::WindowProperty<ShelfID>* const
kShelfID;
Add description.

[flackr, 2014-04-22 17:30:38]

https://codereview.chromium.org/237963019/diff/70001/ash/shelf/shelf_util.h
File ash/shelf/shelf_util.h (right):

https://codereview.chromium.org/237963019/diff/70001/ash/shelf/shelf_util.h#n...
ash/shelf/shelf_util.h:18: extern const aura::WindowProperty<ShelfID>* const
kShelfID;
On 2014/04/22 16:06:13, sky wrote:
> Add description.

Done.

https://codereview.chromium.org/237963019/diff/70001/ash/wm/panels/panel_layo...
File ash/wm/panels/panel_layout_manager_unittest.cc (right):

https://codereview.chromium.org/237963019/diff/70001/ash/wm/panels/panel_layo...
ash/wm/panels/panel_layout_manager_unittest.cc:581: // Restore the pantel; panel
should not be activated by default but callout
On 2014/04/22 14:45:54, Mr4D wrote:
> pantel -> panel

Done.

[flackr, 2014-04-22 17:30:57]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2014-04-22 17:31:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/flackr@chromium.org/237963019/80001

[commit-bot: I haz the power, 2014-04-22 19:35:45]

Change committed as 265330

[James Cook, 2014-04-23 16:06:15]

A revert of this CL has been created in
https://codereview.chromium.org/249063003/ by jamescook@chromium.org.

The reason for reverting is: Causing browser_test failures on main waterfall,
probably due to shelf animations:

EnterpriseKioskApp
AutolaunchWarningCancel
AutolaunchWarningConfirm
KioskEnableCancel
KioskEnableConfirmed

See crbug.com/366142 for stacks.
.

[James Cook, 2014-04-23 16:15:02]

On 2014/04/23 16:06:15, James Cook wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/249063003/ by mailto:jamescook@chromium.org.
> 
> The reason for reverting is: Causing browser_test failures on main waterfall,
> probably due to shelf animations:
> 
> EnterpriseKioskApp
> AutolaunchWarningCancel
> AutolaunchWarningConfirm
> KioskEnableCancel
> KioskEnableConfirmed
> 
> See crbug.com/366142 for stacks.
> .

Sorry, slightly wrong test list (there are also blink assertions causing test
failures). This issue includes these tests:

EnterpriseKioskApp
AutolaunchWarningConfirm
InstallAndLaunchApp
LaunchAppNetworkDown