Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: Source/core/dom/EventHandlerRegistry.h

Issue 237963014: Track scroll event handlers in nested documents (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: More simplification. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EventHandlerRegistry_h 5 #ifndef EventHandlerRegistry_h
6 #define EventHandlerRegistry_h 6 #define EventHandlerRegistry_h
7 7
8 #include "core/dom/ActiveDOMObject.h"
8 #include "core/dom/DocumentSupplementable.h" 9 #include "core/dom/DocumentSupplementable.h"
9 #include "core/events/Event.h" 10 #include "core/events/Event.h"
10 #include "wtf/HashCountedSet.h" 11 #include "wtf/HashCountedSet.h"
11 12
12 namespace WebCore { 13 namespace WebCore {
13 14
14 typedef HashCountedSet<EventTarget*> EventTargetSet; 15 typedef HashCountedSet<EventTarget*> EventTargetSet;
15 16
16 // Registry for keeping track of event handlers. Handlers can either be 17 // Registry for keeping track of event handlers. Handlers can either be
17 // associated with an EventTarget or be "external" handlers which live outside 18 // associated with an EventTarget or be "external" handlers which live outside
18 // the DOM (e.g., WebViewImpl). 19 // the DOM (e.g., WebViewImpl).
19 class EventHandlerRegistry FINAL : public DocumentSupplement { 20 class EventHandlerRegistry FINAL : public DocumentSupplement, private ActiveDOMO bject {
20 public: 21 public:
21 virtual ~EventHandlerRegistry(); 22 virtual ~EventHandlerRegistry();
22 23
23 // Supported event handler classes. Note that each one may correspond to 24 // Supported event handler classes. Note that each one may correspond to
24 // multiple event types. 25 // multiple event types.
25 enum EventHandlerClass { 26 enum EventHandlerClass {
26 ScrollEvent, 27 ScrollEvent,
27 EventHandlerClassCount, // Must be the last entry. 28 EventHandlerClassCount, // Must be the last entry.
28 }; 29 };
29 30
(...skipping 22 matching lines...) Expand all
52 53
53 private: 54 private:
54 explicit EventHandlerRegistry(Document&); 55 explicit EventHandlerRegistry(Document&);
55 56
56 enum ChangeOperation { 57 enum ChangeOperation {
57 Add, // Add a new event handler. 58 Add, // Add a new event handler.
58 Remove, // Remove an existing event handler. 59 Remove, // Remove an existing event handler.
59 RemoveAll // Remove any and all existing event handlers for a given targ et. 60 RemoveAll // Remove any and all existing event handlers for a given targ et.
60 }; 61 };
61 62
63 // Inherited from ActiveDOMObject
64 virtual void stop() OVERRIDE;
65
62 // Returns true if |eventType| belongs to a class this registry tracks. 66 // Returns true if |eventType| belongs to a class this registry tracks.
63 static bool eventTypeToClass(const AtomicString& eventType, EventHandlerClas s* result); 67 static bool eventTypeToClass(const AtomicString& eventType, EventHandlerClas s* result);
64 68
65 // Returns true if the operation actually added a new target or completely 69 // Returns true if the operation actually added a new target or completely
66 // removed an existing one. 70 // removed an existing one.
67 bool updateEventHandlerTargets(ChangeOperation, EventHandlerClass, EventTarg et*); 71 bool updateEventHandlerTargets(ChangeOperation, EventHandlerClass, EventTarg et*);
68 72
69 // Called on the EventHandlerRegistry of the root Document to notify 73 // Called on the EventHandlerRegistry of the root Document to notify
70 // clients when we have added the first handler or removed the last one for 74 // clients when we have added the first handler or removed the last one for
71 // a given event class. |hasActiveHandlers| can be used to distinguish 75 // a given event class. |hasActiveHandlers| can be used to distinguish
(...skipping 13 matching lines...) Expand all
85 OwnPtr<EventTargetSet> targets; 89 OwnPtr<EventTargetSet> targets;
86 }; 90 };
87 91
88 Document& m_document; 92 Document& m_document;
89 HandlerState m_eventHandlers[EventHandlerClassCount]; 93 HandlerState m_eventHandlers[EventHandlerClassCount];
90 }; 94 };
91 95
92 } // namespace WebCore 96 } // namespace WebCore
93 97
94 #endif // EventHandlerRegistry_h 98 #endif // EventHandlerRegistry_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698