Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2379623002: Make UsingEmbedderHeapTracer nicer (Closed)

Created:
4 years, 2 months ago by Marcel Hlopko
Modified:
4 years, 2 months ago
Reviewers:
Michael Lippautz
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make UsingEmbedderHeapTracer nicer BUG= LOG=no Committed: https://crrev.com/3208cdf3471886d3d4331c7bb5c4d61676647855 Cr-Commit-Position: refs/heads/master@{#39839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/heap.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Marcel Hlopko
Ptal, sorry to add it extra, it slipped from previous cl.
4 years, 2 months ago (2016-09-28 15:50:09 UTC) #2
Michael Lippautz
On 2016/09/28 15:50:09, Marcel Hlopko wrote: > Ptal, sorry to add it extra, it slipped ...
4 years, 2 months ago (2016-09-28 19:33:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379623002/1
4 years, 2 months ago (2016-09-28 19:40:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 20:07:20 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 20:07:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3208cdf3471886d3d4331c7bb5c4d61676647855
Cr-Commit-Position: refs/heads/master@{#39839}

Powered by Google App Engine
This is Rietveld 408576698