Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2379613002: [tools] Fix typo in callstats.py (Closed)

Created:
4 years, 2 months ago by Camillo Bruni
Modified:
4 years, 2 months ago
Reviewers:
nickie
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Fix typo in callstats.py and show stdout/stderr with replay BUG= Committed: https://crrev.com/d67aafa6afc9cea7dd41e8bb5954a96bf13400a0 Cr-Commit-Position: refs/heads/master@{#39835}

Patch Set 1 #

Patch Set 2 : fixing redirect #

Total comments: 2

Patch Set 3 : addressing nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M tools/callstats.py View 1 2 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Camillo Bruni
PTAL
4 years, 2 months ago (2016-09-28 14:56:39 UTC) #3
nickie
LGTM, minor comment. https://codereview.chromium.org/2379613002/diff/20001/tools/callstats.py File tools/callstats.py (right): https://codereview.chromium.org/2379613002/diff/20001/tools/callstats.py#newcode49 tools/callstats.py:49: def start_replay_server(args, sites, redirect_output=True): nit: I'd ...
4 years, 2 months ago (2016-09-28 15:00:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379613002/40001
4 years, 2 months ago (2016-09-28 15:06:21 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-28 15:59:40 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/d67aafa6afc9cea7dd41e8bb5954a96bf13400a0 Cr-Commit-Position: refs/heads/master@{#39835}
4 years, 2 months ago (2016-09-28 15:59:56 UTC) #10
Camillo Bruni
4 years, 2 months ago (2016-09-29 08:54:09 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/2379613002/diff/20001/tools/callstats.py
File tools/callstats.py (right):

https://codereview.chromium.org/2379613002/diff/20001/tools/callstats.py#newc...
tools/callstats.py:49: def start_replay_server(args, sites,
redirect_output=True):
On 2016/09/28 at 15:00:32, nickie wrote:
> nit: I'd rather call this discard_output.

fine with me :)

Powered by Google App Engine
This is Rietveld 408576698