Issue 23796005: remove fConvolutionProcs from State, and just use it locally

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23796005: remove fConvolutionProcs from State, and just use it locally (Closed)

Created:
7 years, 3 months ago by reed1

Modified:
7 years, 3 months ago

Reviewers:
humper

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

remove fConvolutionProcs from State, and just use it locally BUG= R=humper@google.com Committed: https://code.google.com/p/skia/source/detail?r=11118

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -45 lines)			Patch
M	src/core/SkBitmapProcState.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	src/core/SkBitmapProcState.cpp	View	2 chunks	+3 lines, -9 lines	0 comments	Download
M	src/core/SkBitmapScaler.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/core/SkBitmapScaler.cpp	View	7 chunks	+8 lines, -8 lines	0 comments	Download
M	src/core/SkConvolver.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkConvolver.cpp	View	6 chunks	+9 lines, -9 lines	0 comments	Download
M	src/opts/SkBitmapProcState_opts_arm.cpp	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	src/opts/opts_check_SSE2.cpp	View	1 chunk	+6 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

humper

On 2013/09/04 20:25:07, reed1 wrote: lgtm -- this is definitely an improvement, especially since we ...

7 years, 3 months ago (2013-09-04 21:07:33 UTC) #2

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

7 years, 3 months ago (2013-09-04 21:25:46 UTC) #3

reed1

7 years, 3 months ago (2013-09-05 20:31:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r11118 (presubmit successful).